Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support biblatex apa citation for legal entry types #8966

Merged
merged 10 commits into from
Aug 1, 2022
Merged

Support biblatex apa citation for legal entry types #8966

merged 10 commits into from
Aug 1, 2022

Conversation

Ognimalf
Copy link
Contributor

@Ognimalf Ognimalf commented Jul 11, 2022 •
edited by ThiloteE
Loading

fixes #8931

Introduces multiple entry types that are based on the BibLaTeX standard.

grafik

grafik

grafik

grafik

grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus
Copy link
Member

Hi @Ognimalf, thanks for your interest in JabRef and your addition. However, I think your additional entry type is misplaced in BibTexEntryTypeDefinitions.java, since we exclusivly implement in that class standard entry types as defined by the documentation (https://www.ctan.org/tex-archive/biblio/bibtex/contrib/doc/). Instead I would ask you to implement it like BiblatexSoftwareEntryTypeDefinitions.java as another class of custom entry types, maybe something called 'precustomized'?

@calixtus calixtus added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jul 11, 2022
@Siedlerchr
Copy link
Member

Please have a look at the checkstyle/reviewdog issues. Import JabRef's code style https://github.com/JabRef/jabref/tree/main/config

@ThiloteE ThiloteE added this to the v5.7 milestone Jul 14, 2022
@Siedlerchr Siedlerchr added status: changes required Pull requests that are not yet complete and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Jul 16, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Ognimalf/main
658cbea 
* upstream/main: (25 commits)
  Update Gradle Wrapper from 7.4.2 to 7.5. (JabRef#8986)
  New translations JabRef_en.properties (Russian) (JabRef#8985)
  [Bot] Update CSL styles (JabRef#8978)
  New Crowdin updates (JabRef#8972)
  New Crowdin updates (JabRef#8969)
  Fix .bat errorlevel handling with pwsh.exe check (JabRef#8965)
  revert jsoup version upgrade
  Fix charset detection with utf16 and others (JabRef#8947)
  Bump classgraph from 4.8.147 to 4.8.149 (JabRef#8968)
  Bump jsoup from 1.15.1 to 1.15.2 (JabRef#8967)
  Keep UTF-8 encoding header if present (JabRef#8964)
  Cleanup index when opening a library (JabRef#8962)
  Refactor context menu entry types changing (JabRef#8957)
  Improvement on check for missing commas when importing or opening a .bib file (JabRef#8840)
  Disable ResearchGateTest on CI (JabRef#8955)
  Bump checkstyle from 10.1 to 10.3.1 (JabRef#8950)
  Bump checkstyle from 10.1 to 10.3.1 (JabRef#8950)
  Bump mariadb-java-client from 2.7.5 to 2.7.6 (JabRef#8953)
  Add notification when adding previous entries to new group configuration (JabRef#8919)
  Remember Sidepane width after restart (JabRef#8936)
  ...
@Siedlerchr
Move apa and biblatex software to own classes
a52410c
@Siedlerchr
Move biblatex software and apa fields to own classes as wel
51d5236
@Siedlerchr Siedlerchr removed the status: changes required Pull requests that are not yet complete label Jul 18, 2022
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 20, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Ognimalf/main
13c0fa8 
* upstream/main:
  Autosave folder and checkbox is remembered (JabRef#9000)
  New Crowdin updates (JabRef#8999)
  Sync group view mode and main table (JabRef#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (JabRef#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (JabRef#8997)
  Bump java-diff-utils from 4.11 to 4.12 (JabRef#8998)
  Fix external group metadata changes are not merged (JabRef#8994)
  New Crowdin updates (JabRef#8995)
  Reworded t in pr (JabRef#8989)
  Fixed checkstyle (JabRef#8990)
  Fix RfcFetcherTest (JabRef#8988)
  Fixes koppor#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982)
@Siedlerchr
checkstyle
2f0f630
@Siedlerchr
Fix optional fields2
a2662fb
@Siedlerchr Siedlerchr changed the title Support apa citation type of jurisdictions Support biblatex apa citation jurisdictions Jul 29, 2022
@Siedlerchr Siedlerchr changed the title Support biblatex apa citation jurisdictions Support biblatex apa citation for legal entry types Jul 29, 2022
koppor
koppor approved these changes Aug 1, 2022
View reviewed changes
src/main/java/org/jabref/model/entry/field/FieldFactory.java
@@ -73,13 +73,23 @@ public static String serializeFieldsList(Collection<Field> fields) {
.collect(Collectors.joining(DELIMITER));
}

public static <T> Field parseField(T type, String fieldName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💕🎉

@koppor koppor merged commit 02f51f7 into JabRef:main Aug 1, 2022
Siedlerchr added a commit that referenced this pull request Aug 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into GSOC-merge-fields
681edea 
* upstream/main: (21 commits)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  New translations JabRef_en.properties (Spanish) (#9003)
  Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677
  Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e
  Autosave folder and checkbox is remembered (#9000)
  New Crowdin updates (#8999)
  Sync group view mode and main table (#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (#8997)
  Bump java-diff-utils from 4.11 to 4.12 (#8998)
  Fix external group metadata changes are not merged (#8994)
  ...
Siedlerchr added a commit that referenced this pull request Aug 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into GSOC22-Three-Way-Merge
02998c0 
* upstream/main: (39 commits)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  New translations JabRef_en.properties (Spanish) (#9003)
  Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677
  Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e
  Autosave folder and checkbox is remembered (#9000)
  New Crowdin updates (#8999)
  Sync group view mode and main table (#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (#8997)
  Bump java-diff-utils from 4.11 to 4.12 (#8998)
  Fix external group metadata changes are not merged (#8994)
  ...
Siedlerchr added a commit to zkl-ai/jabref that referenced this pull request Aug 5, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into improve-DOI-import-…
d26e288 
…failure-dialog

* upstream/main: (31 commits)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (JabRef#9030)
  New Crowdin updates (JabRef#9029)
  [Bot] Update CSL styles (JabRef#9027)
  Add missing translations for AutomaticFieldEditor (JabRef#9028)
  [Bot] Update Journal abbrev list (JabRef#9026)
  Rating in main table (JabRef#9023)
  New Crowdin updates (JabRef#9024)
  New Crowdin updates (JabRef#9016)
  New Crowdin updates (JabRef#9013)
  try to gather more output from LO exception (JabRef#9002)
  Improve Automatic Field Editor Dialog (JabRef#8973)
  Update BST VM to Antlr4 (JabRef#8934)
  Support biblatex apa citation for legal entry types (JabRef#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (JabRef#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (JabRef#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (JabRef#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (JabRef#9005)
  ...
Siedlerchr added a commit that referenced this pull request Aug 6, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-8372
e7374f9 
* upstream/main: (185 commits)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (#9030)
  New Crowdin updates (#9029)
  [Bot] Update CSL styles (#9027)
  Add missing translations for AutomaticFieldEditor (#9028)
  [Bot] Update Journal abbrev list (#9026)
  Rating in main table (#9023)
  New Crowdin updates (#9024)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  ...
Siedlerchr added a commit that referenced this pull request Aug 6, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/o…
966d87c 
…rg.jsoup-jsoup-1.15.2

* upstream/main: (34 commits)
  Refactor of DOI import failure dialog, import format reader and clipboard manager (#8839)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (#9030)
  New Crowdin updates (#9029)
  [Bot] Update CSL styles (#9027)
  Add missing translations for AutomaticFieldEditor (#9028)
  [Bot] Update Journal abbrev list (#9026)
  Rating in main table (#9023)
  New Crowdin updates (#9024)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
bib(la)tex status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
v5.7
Development

Successfully merging this pull request may close these issues.

Support APA Legal citation types
5 participants
@Ognimalf @calixtus @Siedlerchr @koppor @ThiloteE