Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect OS language at NativeDesktop#getDefaultFileChooserDirectory #9835

Closed
wants to merge 2 commits into from

Conversation

koppor
Copy link
Member

@koppor koppor commented May 2, 2023

Fixes #8010 - especially #8010 (comment)

In Germany, the default "documents" folder is ~/Dokumente. Either we mirror all translations in JabRef - or we use FileSystemView.getFileSystemView().getDefaultDirectory().getPath(). (Source: https://stackoverflow.com/a/32914568/873282)

This partially reverts #9222.

Compulsory checks

Preview Give feedback

@koppor
Copy link
Member Author

koppor commented May 3, 2023

omajid/xdg-java@master/src/main/java/org/freedesktop/BaseDirectory.java ?

Not sure what you mean by that. The environment variable XDG_DOCUMENTS_DIR seems to be unset at @dermalikmann s machine - see #8010 (comment) and the code

image

@calixtus
Copy link
Member

calixtus commented May 3, 2023

I will test this on my machine, I noticed that the issue occurs on an Arch Linux distribution like mine either with gnome or KDE. I'm not yet convinced that not having the xdg vars set is an issue of the distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect localization for main directory (e.g., ~/Dokkumente)
3 participants