Respect OS language at NativeDesktop#getDefaultFileChooserDirectory #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracked down the implementation: |
Siedlerchr
reviewed
May 6, 2023
Siedlerchr
reviewed
May 7, 2023
|
This should be tested by someone on Linux. I also enabled the debugger, so please check |
Siedlerchr
reviewed
May 7, 2023
| // Make use of xdg-user-dirs | ||
| // See https://www.freedesktop.org/wiki/Software/xdg-user-dirs/ for details | ||
| try { | ||
| Process process = new ProcessBuilder("xdg-user-dirs", "DOCUMENTS").start(); |
There was a problem hiding this comment.
the script is called xdg-user-dir without the s. Its a mess i know. The ""Toolkit"" is called -dirs but the script that you actually run is called -dir
There was a problem hiding this comment.
I tested it anyways by copying the script with the modified name into my path, and it successfully puts /home/<USER>/Dokumente into the "Main file directory" field.
2 tasks
2 tasks
koppor
added
the
status: ready-for-review
Siedlerchr
approved these changes
May 12, 2023
Siedlerchr
previously approved these changes
May 18, 2023
* upstream/main: (101 commits) Fixed tests by reverting development artifact Fixed checkstyle Fixed test remove empty lines move to entry editor prefs Reduced use of Globals for fileUpdateMonitor, removed unused themeManager vars reformulate Update src/main/java/org/jabref/logic/importer/fileformat/BibtexParser.java fix checkstyle Modernize tests at BibtexParserTest Removed ImportFormatReader from Globals at all Fixes some JavaDoc errors Add newline Really fix order Fix CHANGELOG.md order Fix checkstyle Update CHANGELOG.md move to entry editor editor tab add javadoc checkstyle ... # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/gui/desktop/JabRefDesktop.java
Siedlerchr
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8010 - especially #8010 (comment)
In Germany, the default "documents" folder is
~/Dokumente. Either we mirror all translations in JabRef - or we useFileSystemView.getFileSystemView().getDefaultDirectory().getPath(). (Source: https://stackoverflow.com/a/32914568/873282)Follow-up to #9835: This PR is now using a branch in JabRef's main repo so that a) there are builds and b) other devs can easily update the code, too.
Compulsory checks