-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix direct use of Unicode in PDController #2892
Comments
What symbols belong in the "Table of Symbols" of the SRS document? Is +/- infinite something we want to put in it? Should all functions be displayed as the invLaplace shown there (e.g., with it's parameters)? |
We wouldn't normally don't put mathematical symbols like +/- infinite in the table of symbols. We think of them as part of the mathematical background knowledge. In the terminology of theories that we discussed with @JacquesCarette, I think we can think of mathematical knowledge as a "context" theory. There has to be a point where we stop defining things, or we'll also be defining the symbols +, -, d/dt, etc. For functions, I like when they are given with their type, but I don't think that is necessary in the table of symbols. |
That makes more sense to me. Thank you! It's also interesting to think about how we could systematically retrieve information about the mathematical background knowledge. That seems it would need to be manually listed at the moment. Does that mean we treat the "F(s)" component as part of L inverse's type (and that we should the parameter)? |
We don't currently show the types of the other symbols, so no I don't think (at least for the moment) that we should show the parameter for L inverse. For gradient (∇) in SWHS and noPCM we don't show the arguments. |
…nite integration with infinite bounds to indefinite integration)
…g QDs, remove from symbol table.
…nd remove them from symbol table of pdcontroller.
The I'm not too sure what I was doing with my earlier PR, I think I was completely misunderstanding what @JacquesCarette said. I hope this PR is better! |
Drasil/code/drasil-example/pdcontroller/lib/Drasil/PDController/Unitals.hs
Lines 15 to 18 in 10f9f9e
which was spotted while doing #2865 .
The text was updated successfully, but these errors were encountered: