Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct use of Unicode in PDController #2892

Open
JacquesCarette opened this issue Nov 13, 2021 · 5 comments
Open

Fix direct use of Unicode in PDController #2892

JacquesCarette opened this issue Nov 13, 2021 · 5 comments
Assignees

Comments

@JacquesCarette
Copy link
Owner

symnegInf = variable "-∞"
symposInf = variable ""
symFS = sub (variable "F") $ label "s"
syminvLaplace = variable "L⁻¹[F(s)]"

which was spotted while doing #2865 .

@balacij
Copy link
Collaborator

balacij commented Nov 30, 2021

What symbols belong in the "Table of Symbols" of the SRS document? Is +/- infinite something we want to put in it?

Should all functions be displayed as the invLaplace shown there (e.g., with it's parameters)?

@smiths
Copy link
Collaborator

smiths commented Nov 30, 2021

We wouldn't normally don't put mathematical symbols like +/- infinite in the table of symbols. We think of them as part of the mathematical background knowledge. In the terminology of theories that we discussed with @JacquesCarette, I think we can think of mathematical knowledge as a "context" theory. There has to be a point where we stop defining things, or we'll also be defining the symbols +, -, d/dt, etc.

For functions, I like when they are given with their type, but I don't think that is necessary in the table of symbols.

@balacij
Copy link
Collaborator

balacij commented Nov 30, 2021

That makes more sense to me. Thank you! It's also interesting to think about how we could systematically retrieve information about the mathematical background knowledge. That seems it would need to be manually listed at the moment.

Does that mean we treat the "F(s)" component as part of L inverse's type (and that we should the parameter)?

@smiths
Copy link
Collaborator

smiths commented Nov 30, 2021

We don't currently show the types of the other symbols, so no I don't think (at least for the moment) that we should show the parameter for L inverse. For gradient (∇) in SWHS and noPCM we don't show the arguments.

@balacij balacij self-assigned this Nov 30, 2021
balacij added a commit that referenced this issue Dec 15, 2021
…nite integration with infinite bounds to indefinite integration)
balacij added a commit to balacij/Drasil that referenced this issue Jan 24, 2023
balacij added a commit to balacij/Drasil that referenced this issue Jan 24, 2023
…nd remove them from symbol table of pdcontroller.
@balacij balacij removed their assignment Jan 24, 2023
@balacij
Copy link
Collaborator

balacij commented Jan 24, 2023

The syminvLaplace = variable "L⁻¹[F(s)]" is a bit more tricky. We'll figure this out soon (hopefully), when we re-work functions and vectors.

I'm not too sure what I was doing with my earlier PR, I think I was completely misunderstanding what @JacquesCarette said. I hope this PR is better!

@balacij balacij self-assigned this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants