Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infinity QuantityDicts from PDController, and replace usage #2918

Closed
wants to merge 1 commit into from

Conversation

balacij
Copy link
Collaborator

@balacij balacij commented Dec 15, 2021

Contributes to #2892

Definite integration with infinite bounds becomes indefinite integration, which is why 'stable' changes slightly.

image

…nite integration with infinite bounds to indefinite integration)
@JacquesCarette
Copy link
Owner

Except that seems wrong? We really do want this to display in the 'usual' way.

@JacquesCarette
Copy link
Owner

Removing the infinity symbols from PDController is good (they should be in drasil-data!).

However, there should also be a display rule where if the integral is a definite integral on the whole domain, then it should display using infinite bounds. This is different than an indefinite integral!

@balacij
Copy link
Collaborator Author

balacij commented Dec 16, 2021

Would we want infinity to be represented by a QuantityDict? Do you think it would be better to represent infinity in ModelExpr instead?

Ah, I've forgotten my improper integrals; I felt that something might've been wrong, but I couldn't quite tell what. Thank you! I will revert that change.

@JacquesCarette
Copy link
Owner

We'd want infinity to be represented in the same way pi is. We don't want to embed either of them too deeply into Drasil. Take a look at Range for how I side-stepped having to 'write down' infinity in expressions, but how infinity can still appear in output if we so wish, because it is semantically present in the representation (even if it is not syntactically there).

@balacij balacij marked this pull request as draft January 10, 2022 16:16
@balacij
Copy link
Collaborator Author

balacij commented Mar 3, 2022

Since this PR is stale and I think what @JacquesCarette would require us to rewrite this PR anyways, I'll go ahead and close this PR.

@balacij balacij closed this Mar 3, 2022
@balacij balacij deleted the pdcontrollerInfinity branch March 3, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants