Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor operations #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor operations #30

wants to merge 1 commit into from

Conversation

JamesGallicchio
Copy link
Owner

@JamesGallicchio JamesGallicchio commented Apr 17, 2024 •
edited
Loading

Big refactor of Ops.lean.

  • Improves class names to be consistent/predictable
  • Refactors Fold correctness to be in terms of ToMultiset instead of list permutations. This includes some lemmas about multiset induction to prove properties of a fold.
  • Adds ToSet class as the top of the collection model hierarchy

@JamesGallicchio JamesGallicchio force-pushed the refactor-toset branch 3 times, most recently from 0ca4c3e to fee2b0d Compare April 22, 2024 08:48
@JamesGallicchio JamesGallicchio marked this pull request as ready for review April 22, 2024 08:52
@JamesGallicchio
Copy link
Owner Author

Need to add deprecation notices to all the names that have been changed (eek)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesGallicchio