This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
Updated project to use URLs instead of String paths #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acecilia
force-pushed
the
feature/print-absolute-path-xcode
branch
from
67544cc to
7099529
Compare
|
Looks good to me. Will do some tests sometime later and merge if all looks well. Thanks for the PR! |
Jeehut
reviewed
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
The main changes in this PR are:
url.pathis used now, which returns absolute paths without.or...URL(fileURLWithPath: relativePath, relativeTo: directory)is used now when converting a string to URL. Also, the tests are fixed, and now the path returned for a resource is relative instead of absolute.