Set rust cargo build environment variables in android build.gradle for neon #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2019
|
Putting this on ice until JaneaSystems/nodejs-mobile#193 actually works. |
|
Could we merge these changes now that this is working? |
|
LGTM! This change doesn't seem to affect any old behavior. |
jaimecbernardo
approved these changes
Oct 30, 2019
softdevjs7
added a commit
to softdevjs7/nodejs-mobile-react-native
that referenced
this pull request
Sep 30, 2022
Adds rust cargo build environment variables to build.gradle PR-URL: JaneaSystems/nodejs-mobile-react-native#10 Reviewed-By: Jaime Bernardo <jaime@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As laid out in JaneaSystems/nodejs-mobile#193, it's needed to set some rust cargo environment variables to have a successful neon build.
This depends on neon-bindings/neon#411 to have a successful gradle run, since otherwise neon doesn't build for the correct target.