Support CARGO_BUILD_TARGET triple env #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2019
|
I support that change. I just figured out a very similar solution. In my opinion this should allow neon to do cross compilation. |
|
@dherman what is needed to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on neon!
I'm currently trying to get nodejs-mobile (specifically
nodejs-mobile-react-nativefor Android) to work with neon native modules. In order to have a succeeding neon build, the cli needs to respect theCARGO_BUILD_TARGETenv which could be set by thenodejs-mobile-react-nativegradle script (issue with some more details is over here JaneaSystems/nodejs-mobile#193).