Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs):Script-catalog refactoring #2487

Closed
2 tasks
maduvena opened this issue Sep 28, 2022 · 3 comments
Closed
2 tasks

fix(docs):Script-catalog refactoring #2487

maduvena opened this issue Sep 28, 2022 · 3 comments
Assignees
Labels
area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@maduvena
Copy link
Contributor

  1. All interception scripts will be placed under https://github.com/JanssenProject/jans/tree/main/docs/script-catalog under a folder representing the Type of the script (for e.g. UpdateTokenType, ClientRegistrationType, PersonAuthenticationType etc)

  2. All PersonAuthenticationType scripts will be under https://github.com/JanssenProject/jans/tree/main/docs/script-catalog/person_authentication

  3. Similarly other CustomScriptTypes will be under their respective folders.

This will be the central location for all scripts and the use of integrations folder is deprecated

Subsequently, all setups will pick the script from the catalog

  1. The CE setup folder will not have a duplicated version of this file.
  2. Neither will there be duplicates on CN.

TODOs:

  • Modify the CE setup to pick scripts from the catalog

  • Modify the CN setup to pick scripts from the catalog

@moabu
Copy link
Member

moabu commented Sep 28, 2022

Lets push this through. We need to keep moving forward to lower the duplicates in the repo

CC @iromli

@iromli
Copy link
Contributor

iromli commented Sep 28, 2022

Noted. I will update CN setup after script-catalog is finalized

@maduvena
Copy link
Contributor Author

maduvena commented Sep 28, 2022

notes For CE:

You only need to edit file jans-linux-setup/jans_setup/templates/scripts.ldif after moving the script.
Rule for template name

  1. directories are merged with underscore and dashes are replaced by underscore, e.g., directory-1/another-directory_2 becomes directory_1_another_directory_2
  2. append lowered file name without extension with underscote to directory., e.g., file directory-1/another-directory_2/SampleScript.py becomes directory_1_another_directory_2_samplescript

@moabu moabu added this to the 1.0.3 milestone Sep 29, 2022
@moabu moabu modified the milestones: 1.0.3, 1.0.4 Nov 3, 2022
@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
maduvena added a commit that referenced this issue Nov 14, 2022
@yuriyz yuriyz closed this as completed in 052f91f Nov 14, 2022
@maduvena maduvena reopened this Nov 15, 2022
@yuriyz yuriyz closed this as completed in 402e7ae Nov 15, 2022
@maduvena maduvena reopened this Nov 15, 2022
maduvena added a commit that referenced this issue Nov 15, 2022
@yuriyz yuriyz closed this as completed in 7b66f2b Nov 15, 2022
maduvena added a commit that referenced this issue Nov 16, 2022
yuriyz pushed a commit that referenced this issue Nov 16, 2022
@maduvena maduvena changed the title Script-catalog refactoring fix(docs):Script-catalog refactoring Apr 17, 2023
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality labels Apr 17, 2023
maduvena added a commit that referenced this issue Apr 17, 2023
casa script comes from flex
mo-auto pushed a commit that referenced this issue Apr 17, 2023
casa script comes from flex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants