Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2487 scripts-catalog folder restructuring #2999

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

maduvena
Copy link
Contributor

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 15, 2022
Copy link
Contributor

@devrimyatar devrimyatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleaceholders in scripts.ldif are not correct. Please use these rules

  1. seperate directories with _
  2. replace - with _ in directory names
  3. use only script name, omit extension and use lowercase

Using these rules placeholder for script:
person_authentication/user-cert-external-authenticator/UserCertExternalAuthenticator.py
is
person_authentication_user_cert_external_authenticator_usercertexternalauthenticator

When I try to install from this branch, setup exited with error:

  File "/opt/jans/jans-setup/setup_app/utils/setup_utils.py", line 492, in render_template
    rendered_text = self.fomatWithDict(template_text, format_dict)
  File "/opt/jans/jans-setup/setup_app/utils/setup_utils.py", line 385, in fomatWithDict
    return text % dictionary
KeyError: 'person_authentication_usercertexternalauthenticator'

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants