Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linux-setup): config-api scope creation with static inum #3097

Closed
8 tasks
pujavs opened this issue Nov 28, 2022 · 1 comment
Closed
8 tasks

feat(linux-setup): config-api scope creation with static inum #3097

pujavs opened this issue Nov 28, 2022 · 1 comment
Assignees
@devrimyatar
Labels
comp-jans-linux-setup Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Milestone
1.0.7

Comments

@pujavs
Copy link
Contributor

pujavs commented Nov 28, 2022 •
edited
Loading

Issue: When multiple config-api instances are deployed then multiple scopes are created with same name.
Solution: Simplest and effective solution as proposed by @yuriyz is to use use same inum and rely on DB. All DBs provides unique identifier and enforce it.
image

Description

  1. linux setup will have to refer config-api-rs-protect.json for config-api scope creation rather than swagger spec .
    config-api-rs-protect.json will have three sets of scopes per endpoint scope, groupScope and superScope with inum and name.
    linux-setup will have to create these scopes in DB with specified inum
  2. Scope name and inum will be repeated so code should be able to get the unique sets of scope and create accordingly.
  3. Refer config-api-rs-protect.json from dev branch for development -> https://github.com/JanssenProject/jans/tree/jans-config-fixes
  4. If inum or name of the scope is null or empty then do not create that scope
  5. config-api and setup code will have to be merged in main together.
  6. Related config-api issues 2937 and 2882

  • Development target issue

  • Implementation Details

Prepare

  • Read contribution guidelines
  • Read license information

Identified code changes

linux setup config-api scope creation

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

Document the changes

  • task for updating user guides if needed
  • task for updating installation and configuration guides if needed
  • task for updating developer documentation if needed
  • task for updating technical documentation if needed
@pujavs pujavs added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-linux-setup Component affected by issue or PR labels Nov 28, 2022
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Nov 28, 2022
devrimyatar added a commit that referenced this issue Nov 29, 2022
@devrimyatar
feat: jans-linux-setup config-api scope creation with static inum (ref:
35b3dc9 
#3097)
devrimyatar added a commit that referenced this issue Nov 29, 2022
@devrimyatar
fix: jans-linux-setup create scope if inum exists (ref: #3097)
46549b9
devrimyatar added a commit that referenced this issue Nov 29, 2022
@devrimyatar
feat: jans-linux-setup config-api scope creation (ref: #3097)
749d214
yuriyz added a commit that referenced this issue Nov 30, 2022
@pujavs @moabu
@iromli @mzico @yuremm @yurem @yuriyz @devrimyatar
jans(config-api): static scope id and feature and admin level scopes (#…
34bd41d 
…3126)

* fix(config-api): fix for swagger spec for scope creation and sessoin endpoint filter

* ci: add yurem to linux setup codeowners

* chore(image): sync missing localized attributes for sql and spanner (#2927)

* chore(image): sync missing localized attributes for sql and spanner

* chore(image): sync jans-schema.json template

* Update restarting-services.md (#2941)

Restart command and output were merged which made "copy" / "paste" hard....

* Update restarting-services.md (#2942)

Removed "$" sign from command....

* Update restarting-services.md (#2943)

Adding some other service related info...

* feat: allow to use like with lower together (#2944)

Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

* chore: remove unused merthod (#2945)

Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

* feat(jans-auth-server): corrected GluuOrganization - refactor getOrganizationName() #2947 (#2948)

* feat(config-api): super scope implementation

* feat(config-api): static scope

* feat(config-api): comprehensive claims for authurization

* feat(config-api): endpoint group and admin scope

* feat(config-api): sync with main

* feat(config-api): endpoint group and admin scope

* feat(config-api): scope change - wip

* feat(config-api): scope change - wip

* feat(config-api): scope enhancements

* feat(config-api): scope enhancement

* feat(config-api): scope enhancement wip

* feat(config-api): scope enhancement- wip

* feat(config-api): scope enhancement- wip

* feat: jans-linux-setup config-api scope creation with static inum (ref: #3097)

* feat(config-api): scope enhancement - wip

* fix: jans-linux-setup create scope if inum exists (ref: #3097)

* feat: jans-linux-setup config-api scope creation (ref: #3097)

* feat(config-api): scope enhancement - wip

* feat(config-api): scope enhancement

Co-authored-by: moabu <47318409+moabu@users.noreply.github.com>
Co-authored-by: Isman Firmansyah <iromli@users.noreply.github.com>
Co-authored-by: mzico <mohib@gluu.org>
Co-authored-by: Yuriy M <95305560+yuremm@users.noreply.github.com>
Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Co-authored-by: YuriyZ <yzabrovarniy@gmail.com>
Co-authored-by: Mustafa Baser <mbaser@mail.com>
@moabu moabu added this to the 1.0.7 milestone Jan 9, 2023
@devrimyatar
Copy link
Contributor

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

Labels
comp-jans-linux-setup Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.7
Development

No branches or pull requests
4 participants
@devrimyatar @pujavs @moabu @mo-auto