Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-api): health check response rectification and Agama ADS swagger spec #3293

Merged
merged 4 commits into from
Dec 13, 2022
Merged

feat(config-api): health check response rectification and Agama ADS swagger spec #3293

merged 4 commits into from
Dec 13, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Dec 12, 2022 •
edited
Loading

Prepare

Description

  • 3008: jans-config-api/api/v1/health/live - rectified response type to json
  • 3263: added swagger metadata for Agama ADS endpoint- example response json pending
  • 3292: agama confiiguration search endpoint removed filter pattern match with agFlowMeta field
  • 3296: Modified 1-index based search to 0-index based

Target issue

closes #3008
#3263
#3292
#3296

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Dec 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mo-auto mo-auto added the comp-jans-core Component affected by issue or PR label Dec 13, 2022
@yuriyz yuriyz merged commit faf2888 into main Dec 13, 2022
@yuriyz yuriyz deleted the jans-config-api-3213 branch December 13, 2022 10:52
@mo-auto3 mo-auto3 mentioned this pull request Jan 9, 2023
Merged
This was referenced Jan 9, 2023
Merged
Merged
@mo-auto mo-auto mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix:(jans-cli) error in application liveliness status
3 participants
@pujavs @yuriyz @mo-auto