Skip to content

Commit

Permalink
Fix backport of: Mark more tests as flaky
Browse files Browse the repository at this point in the history
Looks like the backport went wrong here as it included 3 tests which
aren't present at all on `v0.6`. This currently breaks the build on
`v0.6`. Not sure why the checks still passed for the backporting PR:
 #3982

Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
  • Loading branch information
FlorianHockmann committed Sep 15, 2023
1 parent 9553819 commit 145452a
Showing 1 changed file with 0 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

package org.janusgraph.diskstorage.es;

import io.github.artsok.RepeatedIfExceptionsTest;
import org.janusgraph.core.JanusGraph;
import org.janusgraph.core.JanusGraphFactory;
import org.janusgraph.diskstorage.configuration.ModifiableConfiguration;
Expand All @@ -25,7 +24,6 @@
import org.testcontainers.junit.jupiter.Testcontainers;

import java.io.File;
import java.util.concurrent.ExecutionException;

import static org.janusgraph.BerkeleyStorageSetup.getBerkeleyJEConfiguration;

Expand All @@ -41,13 +39,6 @@ public ModifiableConfiguration getStorageConfiguration() {
return getBerkeleyJEConfiguration();
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/3960
@RepeatedIfExceptionsTest(repeats = 3)
@Override
public void indexShouldNotExistAfterDeletion() throws Exception {
super.indexShouldNotExistAfterDeletion();
}

/**
* Test {@link org.janusgraph.example.GraphOfTheGodsFactory#create(String)}.
*/
Expand All @@ -61,18 +52,4 @@ public void testGraphOfTheGodsFactoryCreate() {
JanusGraphIndexTest.assertGraphOfTheGods(gotg);
gotg.close();
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/3651
@RepeatedIfExceptionsTest(repeats = 3)
@Override
public void testDisableAndDiscardManuallyAndDropEnabledIndex() throws Exception {
super.testDisableAndDiscardManuallyAndDropEnabledIndex();
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/3931
@RepeatedIfExceptionsTest(repeats = 3)
@Override
public void testDiscardAndDropRegisteredIndex() throws ExecutionException, InterruptedException {
super.testDiscardAndDropRegisteredIndex();
}
}

0 comments on commit 145452a

Please sign in to comment.