[v0.6] Mark more tests as flaky #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary annotation to repeat flaky tests if necessary for tests described in these issues: * JanusGraph#1457 * JanusGraph#1459 * JanusGraph#1462 * JanusGraph#1464 * JanusGraph#1465 * JanusGraph#1497 * JanusGraph#1498 * JanusGraph#2272 * JanusGraph#3142 * JanusGraph#3356 * JanusGraph#3392 * JanusGraph#3393 * JanusGraph#3651 * JanusGraph#3931 * JanusGraph#3959 * JanusGraph#3960 I went through the recent builds on `master` and checked all failed builds. I think this should handle all flaky tests that occurred in these builds, apart from the TinkerPop test where I just don't know how to deal with it: JanusGraph#3841, but we can of course just address that in another PR. We however also sometimes get failed jobs because of some intermediate issues where a backend cannot be properly set up or teared down for some reason or downloading some artifact just fails. I don't know what we can do to improve this, but I would also consider that out of scope of this PR where I just wanted to deal with failing jobs due to specific tests being flaky. Hopefully, this will already lead to significantly fewer cases where we have to manually restart failed jobs (which I had to do a lot lately for all these Dependabot PRs). I also added a link to the relevant issue to all flaky tests. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de> (cherry picked from commit 2ba933c) # Conflicts: # janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphTest.java # janusgraph-solr/src/test/java/org/janusgraph/diskstorage/solr/CQLSolrTest.java # janusgraph-test/src/test/java/org/janusgraph/diskstorage/cache/ExpirationCacheTest.java
FlorianHockmann
added a commit
to FlorianHockmann/janusgraph
that referenced
this pull request
Sep 15, 2023
Looks like the backport went wrong here as it included 3 tests which aren't present at all on `v0.6`. This currently breaks the build on `v0.6`. Not sure why the checks still passed for the backporting PR: JanusGraph#3982 Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann
added a commit
that referenced
this pull request
Sep 15, 2023
Looks like the backport went wrong here as it included 3 tests which aren't present at all on `v0.6`. This currently breaks the build on `v0.6`. Not sure why the checks still passed for the backporting PR: #3982 Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertov0.6:Questions ?
Please refer to the Backport tool documentation