-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky TinkerPop test g_VX1X_repeatXbothEXcreatedX_whereXwithoutXeXX_aggregateXeX_otherVX_emit_path #3841
Labels
Comments
9 tasks
Do we have any way to use the |
FlorianHockmann
added a commit
to GDATASoftwareAG/janusgraph
that referenced
this issue
Sep 7, 2023
This adds the necessary annotation to repeat flaky tests if necessary for tests described in these issues: * JanusGraph#1457 * JanusGraph#1459 * JanusGraph#1462 * JanusGraph#1464 * JanusGraph#1465 * JanusGraph#1497 * JanusGraph#1498 * JanusGraph#2272 * JanusGraph#3142 * JanusGraph#3356 * JanusGraph#3392 * JanusGraph#3393 * JanusGraph#3651 * JanusGraph#3931 * JanusGraph#3959 * JanusGraph#3960 I went through the recent builds on `master` and checked all failed builds. I think this should handle all flaky tests that occurred in these builds, apart from the TinkerPop test where I just don't know how to deal with it: JanusGraph#3841, but we can of course just address that in another PR. We however also sometimes get failed jobs because of some intermediate issues where a backend cannot be properly set up or teared down for some reason or downloading some artifact just fails. I don't know what we can do to improve this, but I would also consider that out of scope of this PR where I just wanted to deal with failing jobs due to specific tests being flaky. Hopefully, this will already lead to significantly fewer cases where we have to manually restart failed jobs (which I had to do a lot lately for all these Dependabot PRs). Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann
added a commit
to GDATASoftwareAG/janusgraph
that referenced
this issue
Sep 13, 2023
This adds the necessary annotation to repeat flaky tests if necessary for tests described in these issues: * JanusGraph#1457 * JanusGraph#1459 * JanusGraph#1462 * JanusGraph#1464 * JanusGraph#1465 * JanusGraph#1497 * JanusGraph#1498 * JanusGraph#2272 * JanusGraph#3142 * JanusGraph#3356 * JanusGraph#3392 * JanusGraph#3393 * JanusGraph#3651 * JanusGraph#3931 * JanusGraph#3959 * JanusGraph#3960 I went through the recent builds on `master` and checked all failed builds. I think this should handle all flaky tests that occurred in these builds, apart from the TinkerPop test where I just don't know how to deal with it: JanusGraph#3841, but we can of course just address that in another PR. We however also sometimes get failed jobs because of some intermediate issues where a backend cannot be properly set up or teared down for some reason or downloading some artifact just fails. I don't know what we can do to improve this, but I would also consider that out of scope of this PR where I just wanted to deal with failing jobs due to specific tests being flaky. Hopefully, this will already lead to significantly fewer cases where we have to manually restart failed jobs (which I had to do a lot lately for all these Dependabot PRs). I also added a link to the relevant issue to all flaky tests. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann
added a commit
that referenced
this issue
Sep 14, 2023
This adds the necessary annotation to repeat flaky tests if necessary for tests described in these issues: * #1457 * #1459 * #1462 * #1464 * #1465 * #1497 * #1498 * #2272 * #3142 * #3356 * #3392 * #3393 * #3651 * #3931 * #3959 * #3960 I went through the recent builds on `master` and checked all failed builds. I think this should handle all flaky tests that occurred in these builds, apart from the TinkerPop test where I just don't know how to deal with it: #3841, but we can of course just address that in another PR. We however also sometimes get failed jobs because of some intermediate issues where a backend cannot be properly set up or teared down for some reason or downloading some artifact just fails. I don't know what we can do to improve this, but I would also consider that out of scope of this PR where I just wanted to deal with failing jobs due to specific tests being flaky. Hopefully, this will already lead to significantly fewer cases where we have to manually restart failed jobs (which I had to do a lot lately for all these Dependabot PRs). I also added a link to the relevant issue to all flaky tests. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann
added a commit
to FlorianHockmann/janusgraph
that referenced
this issue
Sep 14, 2023
This adds the necessary annotation to repeat flaky tests if necessary for tests described in these issues: * JanusGraph#1457 * JanusGraph#1459 * JanusGraph#1462 * JanusGraph#1464 * JanusGraph#1465 * JanusGraph#1497 * JanusGraph#1498 * JanusGraph#2272 * JanusGraph#3142 * JanusGraph#3356 * JanusGraph#3392 * JanusGraph#3393 * JanusGraph#3651 * JanusGraph#3931 * JanusGraph#3959 * JanusGraph#3960 I went through the recent builds on `master` and checked all failed builds. I think this should handle all flaky tests that occurred in these builds, apart from the TinkerPop test where I just don't know how to deal with it: JanusGraph#3841, but we can of course just address that in another PR. We however also sometimes get failed jobs because of some intermediate issues where a backend cannot be properly set up or teared down for some reason or downloading some artifact just fails. I don't know what we can do to improve this, but I would also consider that out of scope of this PR where I just wanted to deal with failing jobs due to specific tests being flaky. Hopefully, this will already lead to significantly fewer cases where we have to manually restart failed jobs (which I had to do a lot lately for all these Dependabot PRs). I also added a link to the relevant issue to all flaky tests. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de> (cherry picked from commit 2ba933c) # Conflicts: # janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphTest.java # janusgraph-solr/src/test/java/org/janusgraph/diskstorage/solr/CQLSolrTest.java # janusgraph-test/src/test/java/org/janusgraph/diskstorage/cache/ExpirationCacheTest.java
FlorianHockmann
added a commit
that referenced
this issue
Sep 14, 2023
This adds the necessary annotation to repeat flaky tests if necessary for tests described in these issues: * #1457 * #1459 * #1462 * #1464 * #1465 * #1497 * #1498 * #2272 * #3142 * #3356 * #3392 * #3393 * #3651 * #3931 * #3959 * #3960 I went through the recent builds on `master` and checked all failed builds. I think this should handle all flaky tests that occurred in these builds, apart from the TinkerPop test where I just don't know how to deal with it: #3841, but we can of course just address that in another PR. We however also sometimes get failed jobs because of some intermediate issues where a backend cannot be properly set up or teared down for some reason or downloading some artifact just fails. I don't know what we can do to improve this, but I would also consider that out of scope of this PR where I just wanted to deal with failing jobs due to specific tests being flaky. Hopefully, this will already lead to significantly fewer cases where we have to manually restart failed jobs (which I had to do a lot lately for all these Dependabot PRs). I also added a link to the relevant issue to all flaky tests. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de> (cherry picked from commit 2ba933c) # Conflicts: # janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphTest.java # janusgraph-solr/src/test/java/org/janusgraph/diskstorage/solr/CQLSolrTest.java # janusgraph-test/src/test/java/org/janusgraph/diskstorage/cache/ExpirationCacheTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flaky Test
org.apache.tinkerpop.gremlin.process.traversal.step.filter.WhereTest$Traversals Error: org.apache.tinkerpop.gremlin.process.traversal.step.filter.WhereTest$Traversals.g_VX1X_repeatXbothEXcreatedX_whereXwithoutXeXX_aggregateXeX_otherVX_emit_path
master
inmemory
,hbase
,cassandra
,berkeleyje
storage backends). For example,tp-tests (inmemory, -Pjava-11, -Dtest.skip.tp=false -DskipTests=true, 11)
job sometimes fails because of that.Stack Trace 1
Stack Trace 2
The text was updated successfully, but these errors were encountered: