Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase wait time for slow ConfigurationManagementGraphServerTest #3870

Conversation

FlorianHockmann
Copy link
Member

The test has been failing quite often lately, probably simply because it didn't wait long enough for the new graph to be created, at least for slow hardware like we have with GH Actions.

I executed the test at least 10 times with this change in GH Actions and it didn't fail a single time so I guess that this increased timeout is enough.

Fixes #3849


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

The test has been failing quite often lately, probably simply because it
didn't wait long enough for the new graph to be created, at least for
slow hardware like we have with GH Actions.

Fixes JanusGraph#3849

Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @FlorianHockmann !
I was tired restarting this test 2-3 times for each PR 😅
I'm not sure, but it seems VMs in GitHub Actions just got weaker later (not 100% sure here). So, this could be the reason why this test started to fail more often than usually.

BTW. Another failing test in this PR isn't related to your changes. It's another flaky test described in #3841

@FlorianHockmann FlorianHockmann merged commit 1ac6ed1 into JanusGraph:master Jun 30, 2023
@FlorianHockmann FlorianHockmann deleted the Issue_3849_FlakyConfigurationManagementGraphServerTest branch June 30, 2023 07:08
@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v0.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky server test: ConfigurationManagementGraphServerTest.bindingShouldExistAfterGraphIsCreated
4 participants