Fix completed saga from static Start still being persisted#2147
Merged
jeremydmiller merged 2 commits intomainfrom Feb 9, 2026
Merged
Fix completed saga from static Start still being persisted#2147jeremydmiller merged 2 commits intomainfrom
jeremydmiller merged 2 commits intomainfrom
Conversation
…-2073 Skip saga variable when emitting ReturnAction frames in generateForOnlyStartingSaga and DetermineSagaDoesNotExistSteps so that only ConditionalSagaInsertFrame handles saga persistence, respecting the IsCompleted() guard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix ancillary store codegen variable name mismatch by removing OverrideName
call in AncillaryOutboxFactoryFrame that diverged constructor param from body
- Fix ThrowRequiredDataMissingExceptionFrame not replacing {Id} placeholder in
default missing entity message
- Add UseDeveloperExceptionPage to test setups so ThrowException and service
location exceptions are caught as 500 responses
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 11, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Startis persisted regardless of completed state #2073: When a saga's staticStartmethod returns a saga that callsMarkCompleted(), the saga was still persisted to storagegenerateForOnlyStartingSaga()emitted unconditional insert frames (fromSagaPersistenceChainPolicy) for the saga variable before theConditionalSagaInsertFramewhich has theIsCompleted()guardReturnActionframes in bothgenerateForOnlyStartingSaga()andDetermineSagaDoesNotExistSteps(), letting onlyConditionalSagaInsertFramehandle saga persistenceTest plan
Bug_2073_completed_saga_still_persistedwith two cases: completed saga not persisted, non-completed saga persistedBug_2056)🤖 Generated with Claude Code