Fix EntityAttribute codegen for value type identities (GH-2207)#2208
Merged
jeremydmiller merged 1 commit intomainfrom Feb 17, 2026
Merged
Fix EntityAttribute codegen for value type identities (GH-2207)#2208jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
ThrowRequiredDataMissingExceptionFrame unconditionally generated the null-conditional operator (?.) on the identity variable's ToString(), which is invalid C# for value types like Guid, int, long. Now checks IsValueType to emit .ToString() for value types and ?.ToString() for reference types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThrowRequiredDataMissingExceptionFrameunconditionally generatedidentity?.ToString()with the null-conditional operator, which is invalid C# for value types likeGuid,int,long— causing a CS0023 compile errorIdentity.VariableType.IsValueTypeto emit.ToString()for value types and?.ToString() ?? ""for reference typesTest plan
[Entity(OnMissing = OnMissing.ThrowException)]with Guid identityCloses #2207
🤖 Generated with Claude Code