Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select uses addEventListener/removeEventListener, which don't exist in IE8 #175

Closed
StefanBilliet opened this issue May 7, 2015 · 3 comments
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer

Comments

@StefanBilliet
Copy link

Hi

In Select.js->componentWillMount(), you add/remove event listeners for when clicking outside the element. Apparently, IE8 doesn't support addEventListener/removeEventListener; it only supports attachEvent/detachEvent (the name of the click event is also different).
It's fairly simple to fix: StefanBilliet@f0b0048
My question is, are you open to these kinds of fixes?

With kind regards
Stefan Billiet

@dcousens dcousens added the issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer label May 12, 2015
@dcousens
Copy link
Collaborator

@StefanBilliet we are open to these kind of fixes. Please make a PR and we'll put it through the review cycle :)
Before making the PR, please read the CONTRIBUTORS file.

@julen
Copy link
Contributor

julen commented May 23, 2015

Hey, this was fixed in #193, and it should be closed.

@dcousens
Copy link
Collaborator

Thanks @julen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants