Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 175 #193

Merged
merged 1 commit into from
May 19, 2015
Merged

Fix for issue 175 #193

merged 1 commit into from
May 19, 2015

Conversation

StefanBilliet
Copy link

Hi

I mistakenly deleted the wrong branch in my repo, so it took some time to get everything back.
I created a new branch with the one squashed commit; sorry for my blundering.

With kind regards
Stefan Billiet

Fix for issue 175
bdc1c28 
 Squashed commit of the following:

commit 4c02e04
Merge: 8183305 3da945f
Author: Stefan Billiet <sbilliet@csc.com>
Date:   Tue May 12 13:08:49 2015 +0200

     Merge branch 'issue175' of https://github.com/StefanBilliet/react-select into issue175

commit 8183305
Author: Stefan Billiet <sbilliet@csc.com>
Date:   Tue May 12 13:05:59 2015 +0200

    Added es5-shim & es5-sham to the examples page, so that this issue can be
    tested under IE8

commit 3da945f
Author: Stefan Billiet <sbilliet@csc.com>
Date:   Tue May 12 13:05:59 2015 +0200

    Added es5-shim & es5-sham to the examples page, so that this PR can be
    tested under IE8

commit c1054b1
Author: sbillietcsc <sbilliet@csc.com>
Date:   Tue May 12 12:40:16 2015 +0200

    Fixed missing semi-colons

commit cf53043
Merge: f0b0048 25c77bd
Author: Stefan Billiet <sbilliet@csc.com>
Date:   Tue May 12 12:31:57 2015 +0200

     Merge branch 'master' of https://github.com/JedWatson/react-select into issue175

    Conflicts:
    	src/Select.js

commit f0b0048
Author: Stefan Billiet <sbilliet@csc.com>
Date:   Thu May 7 17:47:24 2015 +0200

    Adding support for IE8 in _bindCloseMenuIfClickedOutside and
    _unbindCloseMenuIfClickedOutside
@StefanBilliet StefanBilliet mentioned this pull request May 18, 2015
Closed
@StefanBilliet
Copy link
Author

The reason I added the shim to the example was because there was an error about "Array.isArray is undefined" under IE8. I don't think such things need to be "fixed" for IE8 support, since you can easily use a shim for that.
However, in IE8, binding a click eventhandler happens differently compared to other browsers. The function is different (attachEvent() <-> addEventListener()), but the eventnames differ also ("onclick" <-> "click).
I'm not aware of a shim that could fix that.

@dcousens
Copy link
Collaborator

ACK. @JedWatson please merge

@JedWatson
Copy link
Owner

This is great, thanks @StefanBilliet

JedWatson added a commit that referenced this pull request May 19, 2015
@JedWatson
Merge pull request #193 from StefanBilliet/issue175-squashed
d1ca39b 
Fix for issue 175
@JedWatson JedWatson merged commit d1ca39b into JedWatson:master May 19, 2015
@julen julen mentioned this pull request May 23, 2015
Closed
@dcousens dcousens mentioned this pull request Jun 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JedWatson JedWatson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanBilliet @dcousens @JedWatson