Stop using addEventListener/removeEventListener for IE8 compatibility #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 7, 2015 17:47
_unbindCloseMenuIfClickedOutside
…nto issue175 Conflicts: src/Select.js
…n be tested under IE8
|
Please squash to 1 commit. |
dcousens
changed the title
| @@ -37,7 +37,9 @@ | |||
| <div class="footer"> | |||
| Copyright © Jed Watson 2014. MIT Licensed. | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.1.1/es5-shim.js"></script> | |||
There was a problem hiding this comment.
Without the shim, the example wouldn't run under IE8, so I couldn't verify wether the fix worked.
There was a problem hiding this comment.
If we were going to use a shim, why not just use what we had before?
There was a problem hiding this comment.
because the shim doesn't abstract away the difference in api of attaching an event handler between IE8 and all other browsers
|
@StefanBilliet whats the conclusion? |
|
That I was doing something very stupid with my branches; trying to rectify the situation -_- |
|
I created a new PR here: #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
As discussed in issue 175, here is the pull request.
npm test, npm run lint and npm run style all pass, so I hope everything is in order.
With kind regards
Stefan Billiet