Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why trigger onMenuOpen when handle input change? #3620

Closed
cedcn opened this issue Jun 13, 2019 · 3 comments
Closed

Why trigger onMenuOpen when handle input change? #3620

cedcn opened this issue Jun 13, 2019 · 3 comments

Comments

@cedcn
Copy link

cedcn commented Jun 13, 2019

#3335

@cutterbl
Copy link
Contributor

cutterbl commented Jul 3, 2019

Pretty standard, really. User experience expectation here would be to begin filtering the list of options, if you were to type directly in the Select.

@konstantin-tarasov-clearscale
Copy link

konstantin-tarasov-clearscale commented Dec 27, 2019

I don't agree.
The event should be triggered once the menu is opened.
Why trigger the event on input?
Regarding the onInputChange handler, it is useless and confusing.

pruik pushed a commit to FortesSolutions/react-select that referenced this issue Feb 25, 2020
…selectors on a single page

- Only perform onMenuOpen / onMenuClose if the menu is actually closed / open.
-- Will invalidate PR JedWatson#3897 / Issues JedWatson#3335 JedWatson#3620
@bladey
Copy link
Contributor

bladey commented May 28, 2020

Hello -

In an effort to sustain the react-select project going forward, we're closing old issues.

We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our efforts towards the current major version.

If you aren't using the latest version of react-select please consider upgrading to see if it resolves any issues you're having.

However, if you feel this issue is still relevant and you'd like us to review it - please leave a comment and we'll do our best to get back to you!

@bladey bladey closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants