-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3335 - removes the call to onMenuOpen within handleInputChange #3897
Conversation
🦋 Changeset is good to goLatest commit: 80e7e17 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Although I would agree with you that the
I would suggest wrapping the
|
…selectors on a single page - Only perform onMenuOpen / onMenuClose if the menu is actually closed / open. -- Will invalidate PR JedWatson#3897 / Issues JedWatson#3335 JedWatson#3620
Thanks for your input ! |
…utChange in Select.js
…d (as suggested by pruik)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80e7e17:
|
@pruik suggestion should be implemented. We've faced this issue and needed to implement this solution in our code. I think this should be prioritized.. |
Can verify this is an issue, PR looks good, @JedWatson to confirm the original change wasn't intentional. |
Any updates regarding this bug? |
Hey all, just wanted to check in on this thread -- any idea when the release for this bug fix will happen? I saw the Version Packages PR was not yet merged: |
EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance! |
Hello, i am using 4.3.1 version of react-select and this is still happening... when input is blurred onMenuClose is called even though menu is closed |
@PSoltes Can you a new issue with a CodeSandbox that clearly demonstrates the incorrect behavior? Thanks! |
As discussed in #3335 and #3620 , the expected behavior of
onMenuOpen
is to be triggered when the Menu opens.Currently it is called on every input change as well which is quite confusing.
Removing the call of
onMenuOpen
withinhandleInputChange
gives us the expected behavior.