Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated error type for errors returned by Add, Not and FromStr #221

Closed
JelteF opened this issue Nov 14, 2022 · 0 comments · Fixed by #233 or #235
Closed

Use dedicated error type for errors returned by Add, Not and FromStr #221

JelteF opened this issue Nov 14, 2022 · 0 comments · Fixed by #233 or #235
Assignees
@tyranron
Labels
enhancement
Milestone
1.0.0

Comments

@JelteF
Copy link
Owner

JelteF commented Nov 14, 2022 •
edited
Loading

For consistency with #220 we should have custom error types for Add, Not and FromStr too
@JelteF JelteF added this to the 1.0.0 milestone Nov 14, 2022
@JelteF JelteF changed the title Use dedicated error type for errors returned by Add and Not enum implementations Use dedicated error type for errors returned by Add, Not and FromStr Nov 20, 2022
@tyranron tyranron mentioned this issue Jan 25, 2023
Merged
3 tasks
@tyranron tyranron linked a pull request Jan 25, 2023 that will close this issue
Use dedicated error types for Add and Not derives (#221) #233
Merged
3 tasks
tyranron added a commit that referenced this issue Jan 26, 2023
@tyranron
Use dedicated error types for Add and Not derives (#233, #221)
e3daf2c 
Adds `ops::UnitError`, `ops::WrongVariantError` and `ops::BinaryError` to `derive_more` crate and uses them in `Add`-like and `Not`-like derives.

Additionally:
- Renames `derive_more::errors` module as `derive_more::convert` to follow `std`/`core` naming conventions.
- Adds `#[doc(hidden)]` attribute on to `new()` methods of created error types. This way we mimic them as not public, thus won't introduce breaking changes in future once we need to modify their private fields.
@tyranron tyranron reopened this Jan 26, 2023
@tyranron tyranron self-assigned this Jan 26, 2023
@tyranron tyranron mentioned this issue Jan 26, 2023
Merged
3 tasks
JelteF pushed a commit that referenced this issue Jan 26, 2023
@tyranron
Use dedicated error type for FromStr (#221) (#235)
9014b18 
Part of #221
Resolves #221

## Synopsis

#221 (comment)

## Solution

Adds `FromStrError` type and uses it in `#[derive(FromStr)]` expansion
for enums instead of generating an error type in-place.
liveseed added a commit to liveseed/derive_more that referenced this issue Aug 20, 2024
@liveseed @tyranron
Use dedicated error type for FromStr (#221) (#235)
06f11fd 
Part of #221
Resolves #221

## Synopsis

JelteF/derive_more#221 (comment)

## Solution

Adds `FromStrError` type and uses it in `#[derive(FromStr)]` expansion
for enums instead of generating an error type in-place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyranron tyranron

Labels
enhancement
Projects
None yet
Milestone
1.0.0
2 participants
@JelteF @tyranron