Use dedicated error types for Add
and Not
derives (#221)
#233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #221
Synopsis
See #221 (comment)
Solution
Adds
ops::UnitError
,ops::WrongVariantError
andops::BinaryError
toderive_more
crate and uses them inAdd
-like andNot
-like derives.Additionally:
derive_more::errors
module asderive_more::convert
to followstd
/core
naming conventions.#[doc(hidden)]
attribute on tonew()
methods of created error types. This way we mimic them as not public, thus won't introduce breaking changes in future once we need to modify their private fields.Checklist
Tests are added/updated(if required)