Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathways interface simplification #41

Merged
merged 9 commits into from
Oct 20, 2020
Merged

Pathways interface simplification #41

merged 9 commits into from
Oct 20, 2020

Conversation

luisfabib
Copy link
Collaborator

@luisfabib luisfabib commented Oct 20, 2020

See #39
Simplified the interface for defining dipolar pathways in dipolarkernel and dipolarbackground. Instead of using a matrix for defining the pathways, using NaN for unmodulated pathways, these are now defined as a list of pathways, each being a list of parameters.

Refactored and simplified code for both functions profiting the new interface.

@luisfabib luisfabib added this to the 0.12.0 milestone Oct 20, 2020
@luisfabib luisfabib changed the title Pathways interface simplification (#39) Pathways interface simplification Oct 20, 2020
@luisfabib luisfabib linked an issue Oct 20, 2020 that may be closed by this pull request
@stestoll stestoll marked this pull request as draft October 20, 2020 16:34
@luisfabib luisfabib marked this pull request as ready for review October 20, 2020 16:37
@luisfabib luisfabib requested a review from stestoll October 20, 2020 16:37
deerlab/dipolarbackground.py Outdated Show resolved Hide resolved
deerlab/dipolarkernel.py Show resolved Hide resolved
deerlab/dipolarkernel.py Show resolved Hide resolved
docsrc/source/basics.rst Show resolved Hide resolved
Copy link
Collaborator

@stestoll stestoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some inconsistencies regarding pathinfo vs pathways across several files. I do like pathways, it's more directly linked to the underlying concept. I think we should use it throughout.

@luisfabib
Copy link
Collaborator Author

Yes, I like pathways better too. The current keyword is pathinfo which might be confusing.

@luisfabib luisfabib merged commit 4514b86 into main Oct 20, 2020
@stestoll stestoll deleted the pathways_interface branch October 20, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the pathinfo interface
2 participants