-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathways interface simplification #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some inconsistencies regarding pathinfo
vs pathways
across several files. I do like pathways
, it's more directly linked to the underlying concept. I think we should use it throughout.
Yes, I like |
See #39
Simplified the interface for defining dipolar pathways in
dipolarkernel
anddipolarbackground
. Instead of using a matrix for defining the pathways, using NaN for unmodulated pathways, these are now defined as a list of pathways, each being a list of parameters.Refactored and simplified code for both functions profiting the new interface.