Fix Keyboard disappears on IME action #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Feb 17, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/bug/KeyboardIMEActionPopup.kt
Outdated
Show resolved
Hide resolved
…mo/bug/KeyboardIMEActionPopup.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
|
@ASalavei by the way - it was my mistake, because you copied this code from another commit |
MatkovIvan
approved these changes
Feb 19, 2024
MatkovIvan
changed the title
Kpotko
approved these changes
Feb 19, 2024
igordmn
pushed a commit
that referenced
this pull request
Feb 19, 2024
## Proposed Changes - Fix for Issue when keyboard doesn't disappears on IME action Where was mistake in indices. Because subList have arguments [exclusive, inclusive) ## Testing Added reproducer to Demo iOS app: IosBugs / KeyboardIMEActionPopup ## Issues Fixed - JetBrains/compose-multiplatform#4291 --------- Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
igordmn
added
changelog1.6.1
igordmn
changed the title
igordmn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Where was mistake in indices. Because subList have arguments [exclusive, inclusive)
Testing
Added reproducer to Demo iOS app: IosBugs / KeyboardIMEActionPopup
Issues Fixed