Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ime actions don't work on Ios after showing dialog/bottom sheet #4291

Closed
vlad1710 opened this issue Feb 13, 2024 · 9 comments
Closed

Ime actions don't work on Ios after showing dialog/bottom sheet #4291

vlad1710 opened this issue Feb 13, 2024 · 9 comments
Assignees
@dima-avdeev-jb
Labels
bug Something isn't working ios

Comments

@vlad1710
Copy link

Describe the bug
Ime actions don't work on Ios after showing dialog/bottom sheet

Affected platforms
Select one of the platforms below:

  • iOS

Versions

  • Kotlin version*: 1.9.22
  • Compose Multiplatform version*: tested on 1.6.0-beta02 and 1.6.0-dev1419
  • OS version(s)* (required for Desktop and iOS issues): ios 17.2

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

  1. set an ime action to keyboard options (for example "Done") in text field
  2. tap on text field and press "Done" - it works
  3. open and dismiss dialog or modal bottom sheet
  4. tap on text field and press "Done" - it doesn't work anymore

Expected behavior
ime action works after showing dialog/bottom sheet
@vlad1710 vlad1710 added bug Something isn't working submitted labels Feb 13, 2024
@dima-avdeev-jb dima-avdeev-jb self-assigned this Feb 13, 2024
@dima-avdeev-jb
Copy link
Contributor

Hello! Thanks for this Issue.
Can you please provide a minimal reproducible sample on GitHub?

@vlad1710
Copy link
Author

https://github.com/vlad1710/IssueReport

@dima-avdeev-jb
Copy link
Contributor

Thanks! We reproduced the problem. The problem is with keyboard disappearing, correct?

@vlad1710
Copy link
Author

Yes, keyboard doesn't disappear.
But also i'm not sure if ime actions work how they should. I can't handle modifier's onKeyEvent lambda, there are no events inside it. This bug could be on my side, but it definitely worked in my another app. Please check it if you can. Thanks.

dima-avdeev-jb added a commit to JetBrains/compose-multiplatform-core that referenced this issue Feb 17, 2024
@dima-avdeev-jb
fix issue keyboard dismiss after showing platformLayer
bc011cf 
https://youtrack.jetbrains.com/issue/COMPOSE-1005/Regression-with-keyboard-disappearing
JetBrains/compose-multiplatform#4291
dima-avdeev-jb added a commit to JetBrains/compose-multiplatform-core that referenced this issue Feb 17, 2024
@dima-avdeev-jb
fix issue keyboard dismiss after showing platformLayer
20cb747 
https://youtrack.jetbrains.com/issue/COMPOSE-1005/Regression-with-keyboard-disappearing
JetBrains/compose-multiplatform#4291
@dima-avdeev-jb dima-avdeev-jb mentioned this issue Feb 17, 2024
Merged
@dima-avdeev-jb
Copy link
Contributor

@vlad1710 about onKeyEvent lambda:
Can you please provide another one reproducible sample with this behavior ?

@vlad1710
Copy link
Author

I've updated the sample.

@dima-avdeev-jb
Copy link
Contributor

dima-avdeev-jb commented Feb 19, 2024 •
edited
Loading

@vlad1710 - thanks, I reproduced this issue with onKeyEvent. Also it was reproduced on previous versions.
Created a separate bug about this behavior:

MatkovIvan added a commit to JetBrains/compose-multiplatform-core that referenced this issue Feb 19, 2024
@dima-avdeev-jb @MatkovIvan
Fix keyboard disappear on IME action (#1118)
dd812f0 
## Proposed Changes

  - Fix for Issue when keyboard doesn't disappears on IME action
Where was mistake in indices. Because subList have arguments [exclusive,
inclusive)

## Testing

Added reproducer to Demo iOS app: IosBugs / KeyboardIMEActionPopup

## Issues Fixed
 - JetBrains/compose-multiplatform#4291

---------

Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
igordmn pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Feb 19, 2024
@dima-avdeev-jb @MatkovIvan @igordmn
Fix keyboard disappear on IME action (#1118)
ea72130 
## Proposed Changes

  - Fix for Issue when keyboard doesn't disappears on IME action
Where was mistake in indices. Because subList have arguments [exclusive,
inclusive)

## Testing

Added reproducer to Demo iOS app: IosBugs / KeyboardIMEActionPopup

## Issues Fixed
 - JetBrains/compose-multiplatform#4291

---------

Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
@dima-avdeev-jb
Copy link
Contributor

Should be fixed in 1.6.0-rc03

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima-avdeev-jb dima-avdeev-jb

Labels
bug Something isn't working ios
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlad1710 @dima-avdeev-jb @okushnikov