Fix keyboard closing while scrolling content with Text Fields #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
commented
Sep 12, 2024
| @@ -54,7 +54,6 @@ internal actual fun legacyTextInputServiceAdapterAndService(): | |||
| } | |||
|
|
|||
| override fun stopInput() { | |||
| service.stopInput() | |||
There was a problem hiding this comment.
@igordmn , do you know the reason why this call was added here?
It looks like the session?.dispose() is doing the same but after active session check.
There was a problem hiding this comment.
Probably because I thought that it should be symmetrical and the session is a separate thing.
After looking into details - your fix is indeed correct, and mine wasn't.
igordmn
approved these changes
Sep 12, 2024
ASalavei
added a commit
that referenced
this pull request
Sep 13, 2024
Do not call text input service directly to stop input from the `LegacyPlatformTextInputServiceAdapter` Fixes https://youtrack.jetbrains.com/issue/CMP-6643/iOS-The-keyboard-closes-while-scrolling-textfield-content-which-is-being-partially-overlapped-by-textfield ## Release Notes Fix keyboard closing while scrolling content with Text Fields
|
Added forgotten "### Fixes - iOS" and "- " in the start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not call text input service directly to stop input from the
LegacyPlatformTextInputServiceAdapterFixes https://youtrack.jetbrains.com/issue/CMP-6643/iOS-The-keyboard-closes-while-scrolling-textfield-content-which-is-being-partially-overlapped-by-textfield
Release Notes
Fixes - iOS