Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard closing while scrolling content with Text Fields #1558

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix keyboard closing while scrolling content with Text Fields #1558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...idx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapter.skiko.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ internal actual fun legacyTextInputServiceAdapterAndService():
}

override fun stopInput() {
service.stopInput()
Copy link
Collaborator Author

@ASalavei ASalavei Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igordmn , do you know the reason why this call was added here?
It looks like the session?.dispose() is doing the same but after active session check.

Copy link
Collaborator

@igordmn igordmn Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because I thought that it should be symmetrical and the session is a separate thing.

After looking into details - your fix is indeed correct, and mine wasn't.

session?.dispose()
session = null
}
Expand Down