Allow OverrideOnly method calls for delegation and wrapping in the same class hierarchy #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novotnyr
force-pushed
the
mp-6076-override-only-delegation-wrapping
branch
from
3fedfb7
to
dd6cb26
Compare
helpers
|
Please adjust the title and description of this PR (not |
Replaced by composite allowed usage filter
novotnyr
changed the title
novotnyr
requested review from
LChernigovskaya,
YannCebron and
kesarevs
and removed request for
YannCebron,
kesarevs and
LChernigovskaya
YannCebron
reviewed
Mar 18, 2024
...ier/verifier-core/src/main/java/com/jetbrains/pluginverifier/verifiers/resolution/Methods.kt
Show resolved
Hide resolved
...in/java/com/jetbrains/pluginverifier/usages/overrideOnly/OverrideOnlyMethodUsageProcessor.kt
Show resolved
Hide resolved
novotnyr
force-pushed
the
mp-6076-override-only-delegation-wrapping
branch
from
176a9bb
to
89e2cee
Compare
YannCebron
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
OverrideOnlymethod calls for delegation and wrapping in the same class hierarchyFor example, do not consider
AnAction#updateas a violation ofOverrideOnlyfor delegation and wrapping.ApiUsageFiltermechanism as a plug-in method to filter out unnecessary usages forApiUsageProcessorAnActions andActionGroups.Please note that this is a more general solution than proposed in the IDEA-336988/, as it supports arbitrary classes and methods.
See MP-6077
See IDEA-336988/