Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow OverrideOnly method calls for delegation and wrapping in the same class hierarchy #1068

Merged
merged 31 commits into from
Mar 20, 2024
Merged

Allow OverrideOnly method calls for delegation and wrapping in the same class hierarchy #1068

merged 31 commits into from
Mar 20, 2024

Commits on Mar 12, 2024

  1. Add ASM Method utilities

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e6c9982 View commit details
    Browse the repository at this point in the history

  2. Initial implementation

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8e7305f View commit details
    Browse the repository at this point in the history

  3. Implement detection of super calls and delegate calls of AnAction#update

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4ea357a View commit details
    Browse the repository at this point in the history

  4. Add test-case scenarios for actions invoking update() of other actions

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c45c15d View commit details
    Browse the repository at this point in the history

  5. Polish flow

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ee6fbcf View commit details
    Browse the repository at this point in the history

  6. Create a generalized allowed method invocations for override only

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4022a4e View commit details
    Browse the repository at this point in the history

  7. Delegate to generalized mechanism

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dd6cb26 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary whitespace

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2253a8f View commit details
    Browse the repository at this point in the history

  9. Add KDoc

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    59b8343 View commit details
    Browse the repository at this point in the history

  10. Reduce number of duplicate parameters

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    cff7dbb View commit details
    Browse the repository at this point in the history

  11. Add calling method to parameters

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    148e313 View commit details
    Browse the repository at this point in the history

  12. Use invocation predicate class to filter out necessary calls

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    11be503 View commit details
    Browse the repository at this point in the history

  13. Extract to separate delegate checker class

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2513407 View commit details
    Browse the repository at this point in the history

  14. Refactor to a separate supercall class

    @novotnyr
    novotnyr committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    89a7eb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Add KDoc

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ddca392 View commit details
    Browse the repository at this point in the history

  2. Automatically discover allowed types for delegates

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    495cb22 View commit details
    Browse the repository at this point in the history

  3. Cover ActionGroup calls with OverrideOnly in unit tests

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    fbe7b57 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b19b24d View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary method

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7fe012a View commit details
    Browse the repository at this point in the history

  6. Consolidate method matching

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2a443ef View commit details
    Browse the repository at this point in the history

  7. Move method matching to 

    helpers
    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4284ba9 View commit details
    Browse the repository at this point in the history

  8. Use filtered implementation in the usage processor

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d0fac31 View commit details
    Browse the repository at this point in the history

  9. Implement and use composite API usage filter

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    15cfd9e View commit details
    Browse the repository at this point in the history

  10. Move BinaryClassName alias to method helpers

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bea5393 View commit details
    Browse the repository at this point in the history

  11. Remove technically specific implementation in favour of general one

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    dc349e9 View commit details
    Browse the repository at this point in the history

  12. Extract OverrideOnly super constructor call to a separate class

    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c6b01c8 View commit details
    Browse the repository at this point in the history

  13. Remove superflous class 

    Replaced by composite allowed usage filter
    @novotnyr
    novotnyr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    72dbe05 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Polish

    @novotnyr
    novotnyr committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a039c18 View commit details
    Browse the repository at this point in the history

  2. Test method overrides in java.lang.Object

    @novotnyr
    novotnyr committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a0d7360 View commit details
    Browse the repository at this point in the history

  3. Do not treat java.lang.Object methods as override candidates by default

    @novotnyr
    novotnyr committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    89e2cee View commit details
    Browse the repository at this point in the history

  4. Ignore java.lang.Object methods in overrides

    @novotnyr
    novotnyr committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0e498ef View commit details
    Browse the repository at this point in the history