Improve ContinueButtonView's robustness #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this change: - Updates ContinueButtonView to take its animation properties from higher up to avoid potential inconsistencies between its own syncing with ExplorationProgressController and the one in StateFragmentPresenter (which could potentially be inconsistent). It also ensures the view works correctly when used in question practice sessions. - Ensures ContinueButtonView can be reused across recycles (specifically, that its animation timer doesn't affect a later reuse of the view). Some Bazel build issues were also fixed.
|
@JishnuGoyal PTAL. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix ContinueButtonView robustness issues as part of oppia#4568.
In particular, this change:
Some Bazel build issues were also fixed.