Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index-ring distance for trackpad pinch gesture #36

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

aaronkollasch
Copy link
Collaborator

@aaronkollasch aaronkollasch commented Sep 23, 2022

Scales the threshold to trigger three-finger pinch gestures according to the Index-Ring distance, as set in the Characters tab.

The default charRegIndexRingDistance is 0.33, and the original distance threshold was 0.15, so the distance multiplier should be roughly 0.455.

Fixes #34

@aaronkollasch
Copy link
Collaborator Author

It looks like there are two defaults for charRegIndexRingDistance:

  • 0.33, set in createDefaultPlist
  • 0.3, set in loadSettings2 if the charRegIndexRingDistance key is not found.

I am treating option 1 as the true default, as the charRegIndexRingDistance should be present in any plists derived from the default plist, which suggests that the multiplier should be 0.455 and not 0.5.

@aaronkollasch
Copy link
Collaborator Author

Perhaps in the future, if a Settings... dialog gets added to the Trackpad tab, I might add a slider for trackpadIndexRingDistance, but for now this is a much more minimal PR that still adds customizability. Will merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to trigger three finger pinch-in gestures on Magic Trackpad
1 participant