Fix Two-Fix One-Slide gestures with filtering on #52
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These gestures relied on the sliding finger's movement going to zero, which no longer happened when the LingerInRange and OutOfRange MTTouchStates were filtered. Instead, BreakTouch is also detected as equivalent to a finger's movement going to zero. Also scales the movement threshold by charRegIndexRingDistance - a trackpad-specific scaling factor should be added at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These gestures relied on the sliding finger's movement going to zero, which no longer happened when the
LingerInRangeandOutOfRangeMTTouchStates were filtered. Instead,BreakTouchis also detected as equivalent to a finger's movement going to zero.Also scales the movement threshold by
charRegIndexRingDistance, similar to #36 – a trackpad-specific scaling factor should be added at some point.