Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FavoritesViewModel implementation #62

Closed
3 tasks done
JoaquimLey opened this issue Sep 24, 2018 · 1 comment
Closed
3 tasks done

Fix FavoritesViewModel implementation #62

JoaquimLey opened this issue Sep 24, 2018 · 1 comment
Assignees
@JoaquimLey
Labels
Priority: High Tests: Unit Type: Maintenance

Comments

@JoaquimLey
Copy link
Owner

JoaquimLey commented Sep 24, 2018 •
edited
Loading

Due to the introduction of the Domain layer, the current implementation makes no sense (directly leaking SmsController)

  • Remove all of the SmsController related code

  • Handle (and execute) UseCases

  • Fix Unit tests
@JoaquimLey JoaquimLey self-assigned this Sep 24, 2018
JoaquimLey added a commit that referenced this issue Sep 25, 2018
@JoaquimLey
Create SingleUseCase for ETA requests (and related)
663c636 
Continue migrating the FavoritesViewModel implementation for the UseCase interactors

- Will create a Transport repository that takes the SMSController
- Handles the request and sends back the response.

#62
JoaquimLey added a commit that referenced this issue Sep 25, 2018
@JoaquimLey
Execute UseCases on FavoritesViewModel, Housekeeping
34b55cd 
- Simplified the way how FlowableUseCases are executed
  - Removed a need of a specific Subscriber, and let consumer handle that

- Was wrongly building the useCases instead of executing in the FavVMImpl

- Renamed ui layer model to TransportUiModel (was FavoriteViewObject)

*UiModel will represent the viewState.

#62
JoaquimLey added a commit that referenced this issue Sep 25, 2018
@JoaquimLey
Adding more Favorites implementation (executing UseCases)
a4548c7 
#62
JoaquimLey added a commit that referenced this issue Sep 25, 2018
@JoaquimLey
Fix Factory for FavoritesViewModel (prolly gonna change this)
88dfb65 
- More tests related to favoritesViewmodel with use cases.

#62
JoaquimLey added a commit that referenced this issue Sep 26, 2018
@JoaquimLey
Presentation Mapper tests, FavoriteViewmodel tests
0a1a01d 
#62
JoaquimLey added a commit that referenced this issue Sep 26, 2018
@JoaquimLey
Complete TransoprtMapper tests for List
58a4774 
#62
JoaquimLey added a commit that referenced this issue Sep 29, 2018
@JoaquimLey
Create missing tests for the non-happy path for favorites fetching
6a77788 
#62
JoaquimLey added a commit that referenced this issue Sep 30, 2018
@JoaquimLey
Create data layer
3dd509c 
- Start wiring up with the domain layer, FavoritesrepositoryImpl and tests
- Scaffold TransportDataStore (still no implementation or sources)
  - Still missing tests for these

#62
See also: #63

Local cache starting to creep in ;) #17
@JoaquimLey JoaquimLey mentioned this issue Sep 30, 2018
Merged
@JoaquimLey
Copy link
Owner Author

Closing as handling the remaining use-cases will make more sense when there's a decision (will open a new issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoaquimLey JoaquimLey

Labels
Priority: High Tests: Unit Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoaquimLey