Data source: Shared Preferences #17
Comments
Merged
JoaquimLey
added a commit
that referenced
this issue
Oct 16, 2018
Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69
JoaquimLey
added a commit
that referenced
this issue
Oct 17, 2018
) * Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * SharedPrefMapper tests - Created necessary factory/mock data classes for the SharedPref module Named the mock classes with the SharedPref prefix for #66 #17 #69 * Initial tests for FrameworkLocalStorageImpl Lacking SharedPreferences test setup - Will probably need to move all the Android test libs to androidx variant. #17 #69 * Include stream episode PR to README
JoaquimLey
added a commit
that referenced
this issue
Oct 21, 2018
JoaquimLey
added a commit
that referenced
this issue
Oct 21, 2018
JoaquimLey
added a commit
that referenced
this issue
Oct 22, 2018
* Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * Implement initial SharedPref slot save logic #17, #69 * Add stream ep to README, ignore failing test on shared pref #17, #69
JoaquimLey
added a commit
that referenced
this issue
Oct 24, 2018
JoaquimLey
added a commit
that referenced
this issue
Oct 25, 2018
Merged
JoaquimLey
added a commit
that referenced
this issue
Oct 28, 2018
JoaquimLey
added a commit
that referenced
this issue
Oct 30, 2018
* Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * Test for SharedPreferences all slots free, saves to Slot.ONE #17, #69 * Final touches on frameworkLocalStorageTest Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69 * Add episode to README #84 * Stream Episode 19 (#84) * Final touches on frameworkLocalStorageTest Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69 * Add episode to README #84 * Add klint link * Create stub test class on :presentation This is a reminder for eventual instrumentation tests, stll not sure if makes sense to use though.
JoaquimLey
added a commit
that referenced
this issue
Feb 14, 2019
Feature: Data source from Android `SharedPreferences` Fixes #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subtask of #69
Tasks ⚙
SharedPreferencesfor first versionThe text was updated successfully, but these errors were encountered: