Data Layer V1.0 #69

JoaquimLey · 2018-10-03T21:01:12Z

Already started building on stream14 and stream15

FavoritesRepository Units tests
FavoritesRepository implementation
TransportRepository Units tests
TransportRepository implementation
TransportDataStore Unit testes
TransportDataStore implementation
- Should decide which source to pull data from/to
- Gets the sources via DI
- Check if data is expired/dirty and needs an update

Sources

Shared preferences data source Data source: Shared Preferences #17
- Tests

Decide if SMS actions (requestEta/cancelEta) should come from the repository or the SmsController directly

Other refs: #12, #14

The text was updated successfully, but these errors were encountered:

- Passing unit tests for all the cases #69

#69

- Unit tests - Currently only using the (not yet implemented) FrameworkLocalStorage - Should be implemented by another module that uses SharedPreferences (Android Library) - A little hacky since SharedPrefs will always be Single events and the stream will be finished everytime Also left a lot of NotImplementedError to methods that shouldn't be used until we have a proper DB SharedPrefs will be limited to only 3 saved Entities. #69

Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69

#69

* Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format

Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69

This will be included in the stblib from Kotlin 1.3. #17, #69

Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69

- Created necessary factory/mock data classes for the SharedPref module Named the mock classes with the SharedPref prefix for #66 #17 #69

Lacking SharedPreferences test setup - Will probably need to move all the Android test libs to androidx variant. #17 #69

) * Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * SharedPrefMapper tests - Created necessary factory/mock data classes for the SharedPref module Named the mock classes with the SharedPref prefix for #66 #17 #69 * Initial tests for FrameworkLocalStorageImpl Lacking SharedPreferences test setup - Will probably need to move all the Android test libs to androidx variant. #17 #69 * Include stream episode PR to README

#17, #69

* Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * Implement initial SharedPref slot save logic #17, #69 * Add stream ep to README, ignore failing test on shared pref #17, #69

<3 tests #17, #69

#17, #69

Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69

* Final touches on frameworkLocalStorageTest Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69 * Add episode to README #84

* Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * Test for SharedPreferences all slots free, saves to Slot.ONE #17, #69 * Final touches on frameworkLocalStorageTest Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69 * Add episode to README #84 * Stream Episode 19 (#84) * Final touches on frameworkLocalStorageTest Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69 * Add episode to README #84 * Add klint link * Create stub test class on :presentation This is a reminder for eventual instrumentation tests, stll not sure if makes sense to use though.

JoaquimLey added the Type: Feature label Oct 3, 2018

JoaquimLey self-assigned this Oct 3, 2018

JoaquimLey added a commit that referenced this issue Oct 3, 2018

Implement TransportRepository

999424b

- Passing unit tests for all the cases #69

JoaquimLey added a commit that referenced this issue Oct 3, 2018

Housekeeping

ea5d666

#69

JoaquimLey added a commit that referenced this issue Oct 3, 2018

Fix typo on TransportRepositoryTest

4a06fdf

#69

This was referenced Oct 7, 2018

Stream Episode 16: TransportDataStore implementation #74

Merged

Data source: Shared Preferences #17

Closed

JoaquimLey added a commit that referenced this issue Oct 13, 2018

housekeeping mobile-ui/build.gradle

eafd9af

Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69

JoaquimLey added a commit that referenced this issue Oct 13, 2018

Rename data package to include project name

dcc8c23

#69

JoaquimLey added a commit that referenced this issue Oct 14, 2018

Scaffold stuff for stream episode 17

0ccd949

Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69

GulajavaMinistudio mentioned this issue Oct 14, 2018

Undefined behavior in safe code when slicing a Vec with zero AndroidKotlinID/transport-eta#9

Merged

JoaquimLey added a commit that referenced this issue Oct 16, 2018

Include kotlinx.serialization experimental library for sharedPrefs

ec8b41c

This will be included in the stblib from Kotlin 1.3. #17, #69

JoaquimLey added a commit that referenced this issue Oct 16, 2018

Make SharedPrefTransport model @kotlinx.serialization.Serializable

16d03c1

Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69

JoaquimLey added a commit that referenced this issue Oct 17, 2018

SharedPrefMapper tests

7b6fbf1

- Created necessary factory/mock data classes for the SharedPref module Named the mock classes with the SharedPref prefix for #66 #17 #69

JoaquimLey added a commit that referenced this issue Oct 17, 2018

Initial tests for FrameworkLocalStorageImpl

c2a90fe

Lacking SharedPreferences test setup - Will probably need to move all the Android test libs to androidx variant. #17 #69

GulajavaMinistudio mentioned this issue Oct 18, 2018

Provide built-in AndroidKotlinID/transport-eta#10

Merged

JoaquimLey added a commit that referenced this issue Oct 21, 2018

Implement initial SharedPref slot save logic

9f220f6

#17, #69

JoaquimLey added a commit that referenced this issue Oct 21, 2018

Add stream ep to README, ignore failing test on shared pref

d81ca4e

#17, #69

GulajavaMinistudio mentioned this issue Oct 22, 2018

Optimize shuffle fetch of contiguous AndroidKotlinID/transport-eta#11

Merged

JoaquimLey added a commit that referenced this issue Oct 24, 2018

Fix a bug where the freeSlot wouldn't be correctly found

a1a80e8

<3 tests #17, #69

JoaquimLey added a commit that referenced this issue Oct 25, 2018

Test for SharedPreferences all slots free, saves to Slot.ONE

d3d4400

#17, #69

GulajavaMinistudio mentioned this issue Oct 25, 2018

Stabilize Layout methods AndroidKotlinID/transport-eta#12

Merged

JoaquimLey added a commit that referenced this issue Oct 28, 2018

Final touches on frameworkLocalStorageTest

0748504

Still missing clear all, getAll and make sure observeSharedPreferencesChanges emitts for any changes (missing tests basically). #17, #69

JoaquimLey mentioned this issue Oct 28, 2018

Stream Episode 19 #84

Merged

GulajavaMinistudio mentioned this issue Oct 31, 2018

Update data AndroidKotlinID/transport-eta#13

Merged

JoaquimLey changed the title ~~Data Layer~~ Data Layer V1.0 Oct 31, 2018

JoaquimLey added this to the Beta 0.1 milestone Oct 31, 2018

JoaquimLey mentioned this issue Feb 14, 2019

Feature/data source shared prefs #90

Merged

JoaquimLey closed this as completed Feb 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data Layer V1.0 #69

Data Layer V1.0 #69

JoaquimLey commented Oct 3, 2018 •

edited

Loading

Data Layer V1.0 #69

Data Layer V1.0 #69

Comments

JoaquimLey commented Oct 3, 2018 • edited Loading

Sources

JoaquimLey commented Oct 3, 2018 •

edited

Loading