Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize shuffle fetch of contiguous #11

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

GulajavaMinistudio
Copy link

  • Scaffold sharedpreferences module
  • Attach to store implemetnation
  • Mock data currently being returned

Some housekeeping.

  • Small configurations for CI

Still not working, wanted to make mock work with debug but variants still compain.

  • Test removing ViewModelModule

  • Ci why you no work?

  • Fix lints on CI

  • Working stuff for CI

  • housekeeping mobile-ui/build.gradle

Had to make some changtes while debuging CI fails. This change still makes sense IMO.

JoaquimLey#69

Maintenece commit, not really related to this branch feature.

  • Manifest cleanup and format

  • Scaffold stuff for stream episode 17

Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs
so lint warns me.

For JoaquimLey#17
Ref JoaquimLey#69

  • Housekeeping from previous commit

  • Fix typo in readme

Changed the copy on the stream log section

  • Include kotlinx.serialization experimental library for sharedPrefs

This will be included in the stblib from Kotlin 1.3.

JoaquimLey#17, JoaquimLey#69

  • Make SharedPrefTransport model @kotlinx.serialization.Serializable

Also, fixes and issue where the String was default to which made the serialization fail:

JoaquimLey#17, JoaquimLey#69

  • Implement initial SharedPref slot save logic

JoaquimLey#17, JoaquimLey#69

  • Add stream ep to README, ignore failing test on shared pref

JoaquimLey#17, JoaquimLey#69

* Scaffold sharedpreferences module

- Attach to store implemetnation
- Mock data currently being returned

Some housekeeping.

* Small configurations for CI

Still not working, wanted to make mock work with debug but variants still compain.

* Test removing ViewModelModule

* Ci why you no work?

* Fix lints on CI

* Working stuff for CI

* housekeeping mobile-ui/build.gradle

Had to make some changtes while debuging CI fails. This change still makes sense IMO.

#69

* Rename data package to include project name
#69

* Remove unecessary .gitignore from other packages

Maintenece commit, not really related to this branch feature.

* Manifest cleanup and format

* Scaffold stuff for stream episode 17

Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs
so lint warns me.

For #17
Ref #69

* Housekeeping from previous commit

* Fix typo in readme

Changed the copy on the stream log section

* Include kotlinx.serialization experimental library for sharedPrefs

This will be included in the stblib from Kotlin 1.3.

#17, #69

* Make SharedPrefTransport model @kotlinx.serialization.Serializable

Also, fixes and issue where the String was default to  which made the serialization fail:
 - Kotlin/kotlinx.serialization#115

#17, #69

* Implement initial SharedPref slot save logic

#17, #69

* Add stream ep to README, ignore failing test on shared pref

#17, #69
@GulajavaMinistudio GulajavaMinistudio merged commit e014746 into AndroidKotlinID:develop Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants