Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional BIP32 test vector for hardened derivation with leading zeros #880

Merged
merged 1 commit into from
May 25, 2021
Merged

Additional BIP32 test vector for hardened derivation with leading zeros #880

merged 1 commit into from
May 25, 2021

Conversation

kristapsk
Copy link
Member

@AdamISZ
Copy link
Member

AdamISZ commented May 25, 2021

  • tACK
  • Technically this is the job of python-bitcointx which has already added this test vector. But it doesn't hurt to have defence in depth.
  • I think you added a newline at end of file but there seems to be a couple extra whitespace/newlines there that should be removed.

@AdamISZ
Copy link
Member

AdamISZ commented May 25, 2021

Thanks, feel free to merge.

@kristapsk
Copy link
Member Author

That newline was for some reason added by vim. Removed extra newlines at the end, merging.

@kristapsk kristapsk merged commit 64f3a88 into JoinMarket-Org:master May 25, 2021
@kristapsk kristapsk deleted the bip32-test branch May 25, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapsk @AdamISZ