BIP32: Modified test vectors for hardened derivation with leading zeros #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think old test vectors should not be deleted. They are needed as regression tests. FYI bitcoinj passes the new test vectors without changes. |
dgpv
added a commit
to Simplexum/python-bitcointx
that referenced
this pull request
Nov 4, 2020
The code in bitcointx correctly handles this, but just to be in-sync with the text of the BIP, use the new test vectors submitted in bitcoin/bips#1030 (when it is merged)
silencer-Tsai
force-pushed
the
test-vectors
branch
from
0b967ec
to
b0521f0
Compare
|
@schildbach |
dgpv
added a commit
to Simplexum/python-bitcointx
that referenced
this pull request
Nov 4, 2020
The code in bitcointx correctly handles this, but just to be in-sync with the text of the BIP, use the new test vectors submitted in bitcoin/bips#1030 (when it is merged)
|
Thanks for sharing the test fixture! |
|
So existing Test 3 is for testing if the initial seed -> master generation step works with a 0x00 leading private key part. This makes sense since most implementations perform the HMACs for LGTM |
dgpv
added a commit
to Simplexum/python-bitcointx
that referenced
this pull request
Dec 4, 2020
The code in bitcointx correctly handles this, but just to be in-sync with the text of the BIP, use the new test vectors submitted in bitcoin/bips#1030 (when it is merged)
SomberNight
added a commit
to spesmilo/electrum
that referenced
this pull request
Feb 18, 2021
also yet-to-be-merged test from bitcoin/bips#1030
|
What exactly is the hold-up here? LGTM! |
kristapsk
added a commit
to JoinMarket-Org/joinmarket-clientserver
that referenced
this pull request
May 25, 2021
… leading zeros 516e46a Additional BIP32 test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. Top commit has no ACKs. Tree-SHA512: 7c0d6f988391297ba83fbebb88f890e88d7458a963e58497714f7385a9982a0c5898d8bbfc3852f51ba3b433d419449bb1e1ca95c2832780628123f66a12e1ad
|
ACK, verified that it actually exercises derivation from a private key with leading 0 byte. |
|
ACK b0521f0 |
maflcko
pushed a commit
to bitcoin/bitcoin
that referenced
this pull request
May 31, 2021
…ion with leading zeros 91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. ACKs for top commit: practicalswift: cr ACK 91ef834 sipa: ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte. Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 1, 2021
…derivation with leading zeros 91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. ACKs for top commit: practicalswift: cr ACK 91ef834 sipa: ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte. Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
kristapsk
approved these changes
Jun 7, 2021
t-bast
added a commit
to ACINQ/bitcoin-lib
that referenced
this pull request
Jun 9, 2021
A new test vectors was introduced in bitcoin/bips#1030 because some wallets didn't handle leading zeros correctly in hardened derivation. We already handled that case correctly, but didn't have a test vector for it.
t-bast
added a commit
to ACINQ/bitcoin-kmp
that referenced
this pull request
Jun 9, 2021
A new test vector was introduced in bitcoin/bips#1030 because some wallets didn't handle leading zeros correctly in hardened derivation. We already handled that case correctly, but didn't have a test vector for it.
darosior
added a commit
to darosior/python-bip32
that referenced
this pull request
Jun 9, 2021
We were doing The Right Thing! See bitcoin/bips#1030 Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
|
ACK b0521f0 - tested in darosior/python-bip32#16 |
t-bast
added a commit
to ACINQ/bitcoin-lib
that referenced
this pull request
Jun 14, 2021
A new test vectors was introduced in bitcoin/bips#1030 because some wallets didn't handle leading zeros correctly in hardened derivation. We already handled that case correctly, but didn't have a test vector for it.
t-bast
added a commit
to ACINQ/bitcoin-kmp
that referenced
this pull request
Jun 14, 2021
A new test vector was introduced in bitcoin/bips#1030 because some wallets didn't handle leading zeros correctly in hardened derivation. We already handled that case correctly, but didn't have a test vector for it.
dgpv
added a commit
to Simplexum/python-bitcointx
that referenced
this pull request
Jul 15, 2021
The code in bitcointx correctly handles this, but just to be in-sync with the text of the BIP, use the new test vectors submitted in bitcoin/bips#1030 (when it is merged)
knst
pushed a commit
to knst/dash
that referenced
this pull request
Nov 28, 2023
…derivation with leading zeros 91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. ACKs for top commit: practicalswift: cr ACK 91ef834 sipa: ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte. Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
knst
pushed a commit
to knst/dash
that referenced
this pull request
Nov 30, 2023
…derivation with leading zeros 91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. ACKs for top commit: practicalswift: cr ACK 91ef834 sipa: ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte. Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
UdjinM6
pushed a commit
to knst/dash
that referenced
this pull request
Nov 30, 2023
…derivation with leading zeros 91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. ACKs for top commit: practicalswift: cr ACK 91ef834 sipa: ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte. Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
PastaPastaPasta
pushed a commit
to knst/dash
that referenced
this pull request
Dec 4, 2023
…derivation with leading zeros 91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe) Pull request description: See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030. ACKs for top commit: practicalswift: cr ACK 91ef834 sipa: ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte. Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in bitpay/bitcore-lib#47, iancoleman/bip39#58 and btcsuite/btcutil#172, the private key with leading zeros(i.e. less than 32 bytes) should be padded to 32 bytes when we derive a hardened child private key from a private key.
Unfortunately, the original test vector 3 is not suitable for this case since both keys are 32 bytes.
In the new test vectors, the key m/0H is 31 bytes.
btcsuite/btcutil just fix the bug. See btcsuite/btcutil#182.