This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Generated private key is 31 bytes instead of 32. #47
Labels
Milestone
Comments
Closed
@christianlundkvist while PR not merged/released, you can use |
@fanatid Good tip, thanks! 👍 |
This was referenced Sep 11, 2016
iancoleman
pushed a commit
to iancoleman/bips
that referenced
this issue
Feb 23, 2017
These additional test vectors will ensure all future implementations are interoperable. See iancoleman/bip39#58 and bitpay/bitcore-lib#47
hypo-test
added a commit
to hypo-test/BitcoinBips-713993353
that referenced
this issue
Nov 25, 2018
These additional test vectors will ensure all future implementations are interoperable. See iancoleman/bip39#58 and bitpay/bitcore-lib#47
gitsucker
added a commit
to gitsucker/better-Bitcoin-improvement-proposals
that referenced
this issue
Nov 25, 2018
These additional test vectors will ensure all future implementations are interoperable. See iancoleman/bip39#58 and bitpay/bitcore-lib#47
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The derived() function sometimes returns 31 byte keys. In the
derive()
function here:https://github.com/bitpay/bitcore-lib/blob/master/lib/hdprivatekey.js#L194
there is clearly the intention of having the Buffer padded to 32 bytes. But when testing the resulting private key is not padded. To replicate:
Related: Consensys/eth-lightwallet#60
The text was updated successfully, but these errors were encountered: