Test vectors for BIP32 derivation with leading zeros (to sync with BIP) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgpv
force-pushed
the
modified-bip32-test-vectors
branch
from
def047e
to
4084cc1
Compare
This built-in function is faster, and using it, we can avoid copying as much data around, since each slice will be copying. It also is easier to read.
@classmethod parameter is always a type, so the check was meaningless
This also removes the need for the stream to be seekable
f.tell() was used to get the stream position for better error message, but this means the stream has to be seekable. Instead of this constraint, just check if the stream has 'tell' attribute and provide a lambda that return '<untracked>' for the error message instead of the position
Previously the empty witness that was supplied to CTransaction.__init__ was not checked for compatibility with currently selected witness class for mutable transaction, it just replaced with new CTxWitness() instance. After this change, it is checked that the supplied instance was compatible with new instance
dgpv
force-pushed
the
modified-bip32-test-vectors
branch
from
4084cc1
to
b41a484
Compare
The code in bitcointx correctly handles this, but just to be in-sync with the text of the BIP, use the new test vectors submitted in bitcoin/bips#1030 (when it is merged)
|
Done with 33ededb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)