Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test vectors for BIP32 derivation with leading zeros (to sync with BIP) #55

Closed
wants to merge 15 commits into from
Closed

Test vectors for BIP32 derivation with leading zeros (to sync with BIP) #55

wants to merge 15 commits into from

Commits on Dec 4, 2020

  1. Reset version for further development

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    cacc271 View commit details
    Browse the repository at this point in the history

  2. Use startswith instead of slicing 

    This built-in function is faster, and using it, we can avoid
copying as much data around, since each slice will be copying.
It also is easier to read.
    @ysangkok @dgpv
    ysangkok authored and dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    d56a914 View commit details
    Browse the repository at this point in the history

  3. Fix: ancestor of ScriptBitcoinClass should be ScriptCoinClass

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    5c7fcd0 View commit details
    Browse the repository at this point in the history

  4. Avoid assigning instances of dispatched classes as default kwarg values

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    086351e View commit details
    Browse the repository at this point in the history

  5. Remove reference to non-existing function from the comment

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    2be0fef View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary check from CCoinAddress.get_output_size() 

    @classmethod parameter is always a type, so the check was meaningless
    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    feab926 View commit details
    Browse the repository at this point in the history

  7. Make PartiallySignedTransaction a dispatched class

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    8aad9c0 View commit details
    Browse the repository at this point in the history

  8. Add util.assert_never for static checks of must-be-unreachable code

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    892c0e1 View commit details
    Browse the repository at this point in the history

  9. Make CTransaction.deserialize() logic the same as in Bitcoin Core source 

    This also removes the need for the stream to be seekable
    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    51ca679 View commit details
    Browse the repository at this point in the history

  10. Allow stream in read_psbt_keymap() to not provide tell() 

    f.tell() was used to get the stream position for better error message,
but this means the stream has to be seekable. Instead of this
constraint, just check if the stream has 'tell' attribute and provide
a lambda that return '<untracked>' for the error message instead of the
position
    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    3983d8a View commit details
    Browse the repository at this point in the history

  11. Improve logic around empty witness in CTransaction.__init__ 

    Previously the empty witness that was supplied to CTransaction.__init__
was not checked for compatibility with currently selected witness
class for mutable transaction, it just replaced with new CTxWitness() instance.
After this change, it is checked that the supplied instance was compatible
with new instance
    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    fb00ad4 View commit details
    Browse the repository at this point in the history

  12. Use unserscore prefix for helper function in tests so pytest ignores it

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    1422eec View commit details
    Browse the repository at this point in the history

  13. Use warnings.warn instead of log.warning in tests

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    40233aa View commit details
    Browse the repository at this point in the history

  14. Allow to grind ECDSA signature to have low-R

    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    db9933c View commit details
    Browse the repository at this point in the history

  15. Test vectors for BIP32 derivation with leading zeros (to sync with BIP) 

    The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)
    @dgpv
    dgpv committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    b41a484 View commit details
    Browse the repository at this point in the history