Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Support coinjoin transactions with no change output #418

Open
raedah opened this issue Feb 7, 2016 · 1 comment
Open

Support coinjoin transactions with no change output #418

raedah opened this issue Feb 7, 2016 · 1 comment

Comments

@raedah
Copy link
Contributor

raedah commented Feb 7, 2016

As mentioned in pull requests #407 and #413, the current code is always assigning a change output, even in cases where there is no change, so the change output has a value of zero which creates an invalid transaction. #413 patches it so that it fails early and with an error msg. I am opening this issue to track fixing this case for when there is no change and the transaction can go through without a change output needed.

#407 (comment)
Quoting belcher here: "coinjoin sending with no change address (i.e. sweeping) has never really been supported. It's not clear where the maker fees would go. Although it might be useful in the rare occasion when the maker gets an order for exactly the right coinjoin amount."

adlai added a commit to adlai/joinmarket that referenced this issue Feb 10, 2016
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
adlai added a commit to adlai/joinmarket that referenced this issue Feb 10, 2016
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
@raedah
Copy link
Contributor Author

raedah commented Feb 10, 2016

This will be useful for allowing yield generators to make offers which clear out mix depth dust, as well as other offers which are intended to match utxo size with no change.

adlai added a commit to adlai/joinmarket that referenced this issue Jul 16, 2016
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
adlai added a commit to adlai/joinmarket that referenced this issue Oct 3, 2017
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
adlai added a commit to adlai/joinmarket that referenced this issue Oct 3, 2017
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
adlai added a commit to adlai/joinmarket that referenced this issue Oct 3, 2017
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants