This repository has been archived by the owner on May 13, 2022. It is now read-only.
skip empty change addresses for makers #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlai
force-pushed
the
sweep-empty-change
branch
from
3bb8cbd
to
4125c93
Compare
|
I have read the diff and I think it's not wrong. |
|
Could someone else have a look at this before we merge, it contains modifications to |
|
Taking a look now, will feed back if I have a comment. |
|
We can surely merge this now? |
adlai
force-pushed
the
sweep-empty-change
branch
from
4125c93
to
226bcf8
Compare
Closed
AdamISZ
force-pushed
the
develop
branch
3 times, most recently
from
97d2603
to
47479d5
Compare
adlai
force-pushed
the
sweep-empty-change
branch
2 times, most recently
from
23e3805
to
74fa861
Compare
works towards JoinMarket-Org#418 but does not enable this behavior maker-side
adlai
force-pushed
the
sweep-empty-change
branch
from
74fa861
to
855c866
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works towards #418 but does not enable this behavior maker-side; that would require recognizing when a subset of utxos match the cjout size precisely, and short-circuiting past the addition of a dust amount.