Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite origin support for image urls in development #690

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

jrmyio
Copy link
Contributor

@jrmyio jrmyio commented Jan 26, 2024

Fixes: #568

Add vite origin support for image urls in development.

Add vite `origin` support for image urls in development
Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: ad51a82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.61%. Comparing base (0cc2c68) to head (7837fb8).
Report is 13 commits behind head on main.

❗ Current head 7837fb8 differs from pull request most recent head ad51a82. Consider uploading reports for the commit ad51a82 to get more accurate results

Files Patch % Lines
packages/vite/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   93.60%   93.61%           
=======================================
  Files          32       32           
  Lines        1189     1190    +1     
  Branches      189      190    +1     
=======================================
+ Hits         1113     1114    +1     
  Misses         76       76           
Flag Coverage Δ
imagetools-core 93.61% <0.00%> (-3.40%) ⬇️
vite-imagetools 93.61% <0.00%> (+15.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benmccann benmccann merged commit dc25e4b into JonasKruckenberg:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect Vite's "server.origin" option.
2 participants