Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite origin support for image urls in development #690

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Add vite origin support for image urls in development #690

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e217d43
Add vite `origin` support for image urls in development
jrmyio Jan 26, 2024
fee1b6f
Remove using origin from root config object
jrmyio Mar 26, 2024
075b4e5
Use post.posix.join to support windows
jrmyio Mar 26, 2024
7837fb8
Update packages/vite/src/index.ts
benmccann Mar 26, 2024
ad51a82
Create quiet-bulldogs-appear.md
benmccann Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
if (viteConfig.command === 'serve') {
const id = await generateImageID(srcURL, config, img)
generatedImages.set(id, image)
metadata.src = basePath + id
metadata.src = path.posix.join(viteConfig?.server?.origin ?? '', basePath) + id;

Check warning on line 131 in packages/vite/src/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/vite/src/index.ts#L131 

Added line #L131 was not covered by tests
benmccann marked this conversation as resolved.
Show resolved Hide resolved
} else {
const fileHandle = this.emitFile({
name: basename(srcURL.pathname, extname(srcURL.pathname)) + `.${metadata.format}`,
Expand Down
Loading