feature/18-task-sel-filt into develop #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na_error_handler` test list, started first case of test. - Also added utl sections and tasks fixtures (with some small changes to old fixtures). - Also added `_TASK_TEMPLATE` to `tester_data`.
…tils`. No tests yet. Also added new `general/utils.py`, with `is_date_only()` checker (with unit test).
…me differently based on whether it is a greater than/eq or a less than/eq check.
…is issue); added `use_tzinfo` (rules config change coming NOT in this issue, if ever); timezone factored in for date-only to differentiate between target timezone and machine timezone; assumed time added if time duration provided; fixed missing logic in detecting date-only `relativedelta`; unit test for `_filter_tasks_by_datetime()` started, working so far...
…r `_filter_tasks_by_datetime()` finished, with some reordering and extras added to make it easier to use. ...now let's never think about timezones ever again.
…cal vars, make code cleaner.
…o due date cases covered. Added error message to assertion. `fixture_sections_in_utl_test()` moved to new `/tests/unit/asana/conftest.py` so can be shared with modules in `/test/unit/asana`, allowing `fixture_tasks_with_due_in_utl_test()` to be added.
… off!). Changed how filtered test results are compared (but no new test cases yet).
…arg to that function for unit test purposes.
…s_by_completed()` added, arg added to `get_filtered_tasks()`, all unit tests complete.
…y use datetime field` parameter added.
…ring to maximize compatibility with this code.
…stead of `only use datetime field`. Added reading and checking of these options in `MoveTasksRule`, with `parse_time_arg()` method added and `config.UnsupportedFormatError` added to support.
…w cases for new keys. Also made `test-move-tasks-full` a test by itself without counting on it filling in for a specific case -- duplicates, but easier to see. Some small tweaks to error messages.
… to use `use_tzinfo` for most tests. Hopefully successfully added another test case that will work regardless of timezone while testing the omission of the `use_tzinfo` arg...
Codecov Report
@@ Coverage Diff @@
## develop #32 +/- ##
===========================================
- Coverage 100.00% 99.76% -0.24%
===========================================
Files 12 13 +1
Lines 341 433 +92
===========================================
+ Hits 341 432 +91
- Misses 0 1 +1
Continue to review full report at Codecov.
|
…ure of codecov miss...tested to confirm definitely hitting the line it complained about...
|
Not fixing code coverage on this PR -- will leave failing. Will be fixed in #33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functionality to get tasks from the asana API and to filter them based on due date/time and completion status. A few other tweaks needed to be made along the way on this adventure though...
is_date_only()checker.assumed time for min/max dueadded torules.confforMoveTasksRule, with notes on how to use it.parse_time_arg()added toRuleto support parsing the new arg.relativedelta().fixture_sections_in_utl_test()moved from/tests/unit/asana/test_client.pyto new/tests/unit/asana/conftest.pyso it can be used by multiple modules in that subpackage._TASK_TEMPLATEadded totester_date./asana_extensions/general/utils.pyadded, with corresponding unit test module....and so much more...
Closes #18.